Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2590883002: Make FieldTrialList usable after clearing VariationsParamsManager. (Closed)

Created:
4 years ago by fhorschig
Modified:
4 years ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FieldTrialList usable after clearing VariationsParamsManager. Calling |ClearAllVariationParams| will now create a new instance of the FieldTrialList so |SetVariationParamsWithFeatureAssociations| will work again. BUG=672010 Committed: https://crrev.com/e0bf6128f18eedd05c1525c09d258df0080e8583 Cr-Commit-Position: refs/heads/master@{#439824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/variations/variations_params_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
fhorschig
Hi rkaplow@, Could you please take a look at the 2 new lines?
4 years ago (2016-12-20 13:29:22 UTC) #2
rkaplow
lgtm cool thanks for fix
4 years ago (2016-12-20 15:30:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590883002/1
4 years ago (2016-12-20 16:32:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 16:53:37 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 16:55:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0bf6128f18eedd05c1525c09d258df0080e8583
Cr-Commit-Position: refs/heads/master@{#439824}

Powered by Google App Engine
This is Rietveld 408576698