Refactored the policy code to avoid BrowserThread.

Refactored the policy code to avoid BrowserThread.

The policy code now mostly uses TaskRunners, so that it can move into a
component without DEPS layering violations. The remaining classes that use
BrowserThread directly are meant to stay in //chrome and instantiate the policy
system.

Also cleaned up some unused includes and unused arguments.

BUG=271392
[email protected], [email protected], [email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229404

[Joao da Silva, 2013-10-16 21:33:44]

Please review:

@Daniel: the whole shebang

@Julian: chromeos/settings; a glance at the other policy/ changes would also be
nice :-)

@Elliot: profile_impl.cc

Thanks!

[Elliot Glaysher, 2013-10-16 22:36:10]

profiles lgtm

[Joao da Silva, 2013-10-17 08:27:28]

Just realized that both Julian and Mattias are OOO.

Nikita, can you review chrome/browser/chromeos/settings changes? Thanks!

[dconnelly, 2013-10-17 08:43:03]

LGTM, just a couple of questions.

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/t...
File chrome/browser/policy/cloud/test_request_interceptor.cc (left):

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/t...
chrome/browser/policy/cloud/test_request_interceptor.cc:235: size_t
TestRequestInterceptor::GetPendingSize() const {
Why is this removed?

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/u...
File chrome/browser/policy/cloud/user_cloud_policy_store.cc (left):

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/u...
chrome/browser/policy/cloud/user_cloud_policy_store.cc:149:
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
Do we not want any check at all?

[Joao da Silva, 2013-10-17 08:46:34]

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/t...
File chrome/browser/policy/cloud/test_request_interceptor.cc (left):

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/t...
chrome/browser/policy/cloud/test_request_interceptor.cc:235: size_t
TestRequestInterceptor::GetPendingSize() const {
On 2013/10/17 08:43:03, dconnelly wrote:
> Why is this removed?

Because PostToIOAndWait is a member method now and isn't const.

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/u...
File chrome/browser/policy/cloud/user_cloud_policy_store.cc (left):

https://codereview.chromium.org/26211008/diff/1/chrome/browser/policy/cloud/u...
chrome/browser/policy/cloud/user_cloud_policy_store.cc:149:
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
On 2013/10/17 08:43:03, dconnelly wrote:
> Do we not want any check at all?

I think this is very low value. If we must then we can grab
MessageLoopProxy::current() at the ctor and
DCHECK(origin_loop_->RunsTasksOnCurrentThread()) but I don't think it's worth
it.

[Nikita (slow), 2013-10-17 11:38:10]

https://codereview.chromium.org/26211008/diff/1/chrome/browser/chromeos/setti...
File chrome/browser/chromeos/settings/session_manager_operation.cc (right):

https://codereview.chromium.org/26211008/diff/1/chrome/browser/chromeos/setti...
chrome/browser/chromeos/settings/session_manager_operation.cc:151:
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
FILE thread?

We're supposed to be migrating off the FILE thread and user BlockingPoll
instead.

[Joao da Silva, 2013-10-17 13:38:00]

@Nikita: PTAL at chromeos/settings

@Daniel: please go over chromeos/policy changes again, a couple more classes
have been modified there.

https://codereview.chromium.org/26211008/diff/1/chrome/browser/chromeos/setti...
File chrome/browser/chromeos/settings/session_manager_operation.cc (right):

https://codereview.chromium.org/26211008/diff/1/chrome/browser/chromeos/setti...
chrome/browser/chromeos/settings/session_manager_operation.cc:151:
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
On 2013/10/17 11:38:11, Nikita Kostylev wrote:
> FILE thread?
> 
> We're supposed to be migrating off the FILE thread and user BlockingPoll
> instead.

Right, done.

Initially this change was just about replacing BrowserThread with TaskRunners
without changing the actual backing threads; I've now bitten the bullet and gone
TaskRunner + BlockingPool the whole way.

[dconnelly, 2013-10-17 13:44:48]

lgtm

[Nikita (slow), 2013-10-17 14:11:14]

lgtm, thanks!

[Joao da Silva, 2013-10-18 13:40:39]

Committed patchset #4 manually as r229404 (presubmit successful).

[pfeldman, 2013-10-18 14:37:34]

> Committed patchset #4 manually as r229404 (presubmit successful).

... and rolled out as r229411

Please use try bots and cq.