Display: set color_depth and depth_per_component value based on kEnableHDROutput

Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWfBgAJ 

BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2742383006
Cr-Commit-Position: refs/heads/master@{#459288}
Committed: https://chromium.googlesource.com/chromium/src/+/7c149655e1546c3bb4478f4dca931e5ad35d4073

[mlamouri (slow - plz ping), 2017-03-14 21:15:35]

Description was changed from

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

In the future, we should set the values on display::Display instead of
hardcoding too values.

BUG=701466
==========

to

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

BUG=701466
==========

[mlamouri (slow - plz ping), 2017-03-14 21:15:38]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:16:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-03-14 21:16:47]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected]

[mlamouri (slow - plz ping), 2017-03-14 21:16:47]

hubbe@ and ccameron@, PTAL :)

nasko@, I will need an OWNERS look at the changes in content/

[commit-bot: I haz the power, 2017-03-14 21:24:56]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-14 21:24:57]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mlamouri (slow - plz ping), 2017-03-14 21:36:34]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:37:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 21:47:48]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-14 21:47:49]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mlamouri (slow - plz ping), 2017-03-14 21:50:35]

Description was changed from

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

BUG=701466
==========

to

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mlamouri (slow - plz ping), 2017-03-14 21:50:46]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:51:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-03-14 21:53:07]

lgtm

[commit-bot: I haz the power, 2017-03-14 21:56:49]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-14 21:56:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[ccameron, 2017-03-14 23:15:22]

lgtm

[nasko, 2017-03-14 23:41:33]

content/ rubberstamp LGTM

[mlamouri (slow - plz ping), 2017-03-15 00:01:31]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:10:17]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-15 00:10:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[mlamouri (slow - plz ping), 2017-03-15 00:25:39]

The CQ bit was checked by [email protected] to run a CQ dry run

[mlamouri (slow - plz ping), 2017-03-15 00:26:03]

Description was changed from

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWf...


BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-03-15 00:26:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-03-15 00:27:52]

[email protected] changed reviewers:
+ [email protected]

[mlamouri (slow - plz ping), 2017-03-15 00:27:52]

+jbauman@ for gpu/ changes

[jbauman, 2017-03-15 00:30:41]

lgtm

[commit-bot: I haz the power, 2017-03-15 02:05:40]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-15 02:05:41]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-03-15 20:59:26]

FYI: renamed kEnableHDROutput to just kEnableHDR, so this CL will require a
small merge.

[mlamouri (slow - plz ping), 2017-03-16 11:49:20]

On 2017/03/15 at 20:59:26, hubbe wrote:
> FYI: renamed kEnableHDROutput to just kEnableHDR, so this CL will require a
small merge.

Thanks for the heads up. I'm still waiting for privacy approval.

[mlamouri (slow - plz ping), 2017-03-22 18:44:46]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:41:14]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-22 21:41:16]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-03-23 19:40:36]

The CQ bit was checked by [email protected]

[mlamouri (slow - plz ping), 2017-03-23 19:40:37]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/2742383006/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-23 19:41:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:10:23]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-23 20:10:25]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mlamouri (slow - plz ping), 2017-03-23 20:46:42]

The CQ bit was checked by [email protected]

[mlamouri (slow - plz ping), 2017-03-23 20:46:43]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/2742383006/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-23 20:47:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-03-23 21:37:48]

The CQ bit was unchecked by [email protected]

[mlamouri (slow - plz ping), 2017-03-23 21:37:51]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2017-03-23 21:38:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:43:37]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-23 22:43:38]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[mlamouri (slow - plz ping), 2017-03-23 23:31:25]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2017-03-23 23:32:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-03-23 23:50:29]

Description was changed from

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWf...


BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWf...


BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mlamouri (slow - plz ping), 2017-03-23 23:50:34]

The CQ bit was unchecked by [email protected]

[mlamouri (slow - plz ping), 2017-03-23 23:50:38]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2017-03-23 23:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:00:15]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490313038872720,
"parent_rev": "cccbe41d5ebad5b6e7789c9a18cbdb1bf3b06794", "commit_rev":
"7c149655e1546c3bb4478f4dca931e5ad35d4073"}

[commit-bot: I haz the power, 2017-03-24 00:01:03]

Description was changed from

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWf...


BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWf...


BUG=701466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2742383006
Cr-Commit-Position: refs/heads/master@{#459288}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c149655e1546c3bb4478f4dca93...
==========

[commit-bot: I haz the power, 2017-03-24 00:01:06]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7c149655e1546c3bb4478f4dca93...