Issue 2744663004: No longer send or process the socket recieve buffer value in QUIC. Protected by FLAGS_quic_reloada…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2744663004: No longer send or process the socket recieve buffer value in QUIC. Protected by FLAGS_quic_reloada… (Closed)

Created:
3 years, 9 months ago by Jo Kulik

Modified:
3 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

No longer send or process the socket recieve buffer value in QUIC. Protected by FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer. Merge internal change: 148785639 [email protected] BUG=

Patch Set 1 #

Total comments: 2

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -12 lines)			Patch
M	net/quic/core/quic_config.h	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	net/quic/core/quic_config.cc	View	5 chunks	+17 lines, -4 lines	1 comment	Download
M	net/quic/core/quic_config_test.cc	View	6 chunks	+22 lines, -8 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2739313002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

3 years, 9 months ago (2017-03-10 05:37:44 UTC) #2

https://codereview.chromium.org/2744663004/diff/1/net/quic/core/quic_config.cc
File net/quic/core/quic_config.cc (right):

https://codereview.chromium.org/2744663004/diff/1/net/quic/core/quic_config.c...
net/quic/core/quic_config.cc:549:
QUIC_FLAG_COUNT_N(gfe2_reloadable_flag_quic_no_socket_receive_buffer, 1, 3);
ditto. I'm perplexed by why the script missed this?

https://codereview.chromium.org/2744663004/diff/1/net/quic/core/quic_config.h
File net/quic/core/quic_config.h (right):

https://codereview.chromium.org/2744663004/diff/1/net/quic/core/quic_config.h...
net/quic/core/quic_config.h:439: // Latched copy of
gfe2_reloadable_flag_quic_no_socket_receive_buffer.
I'm surprised the script didn't fix this. Can you tweak the name here?

Expand Messages | Collapse Messages