[Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there.

[Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there.

This is part of AssemblyProgram reduction effort. Details:
- Add Disassembler::Disassemble() and dedup separate PE/ELF versions.
  - Instantiate AssemblyProgram there; replaces old behavior where
    caller (program_detector.cc) instantiates and passes as out param.
- Add virtual Disassembler::GetInstructionGenerator().
  - Remove InstructionGenerator's AssemblyProgram* param; update tests.
- Move InstructionReceptor and InstructionGenerator from AssemblyProgram
  to new file instruction_utils.h.
- Rename ParseAbs32Relocs() to ExtractAbs32Locations(); make common.
- Rename ParseRel32Relocs() to ExtractRel32Locations(); make common.
- Make DisassemblerElf32::abs32_locations_ non-mutable.

BUG=660980
Review-Url: https://codereview.chromium.org/2771753004
Cr-Commit-Position: refs/heads/master@{#459272}
Committed: https://chromium.googlesource.com/chromium/src/+/257f9fb084fd9c3a660ef8d7fd2948cb3d3fd1fb

[huangs, 2017-03-23 18:51:22]

[email protected] changed reviewers:
+ [email protected]

[huangs, 2017-03-23 18:51:24]

PTAL, thanks!

https://codereview.chromium.org/2771753004/diff/1/courgette/disassembler_elf_...
File courgette/disassembler_elf_32.h (right):

https://codereview.chromium.org/2771753004/diff/1/courgette/disassembler_elf_...
courgette/disassembler_elf_32.h:18: #include "courgette/instruction_utils.h"
Including for InstructionGenerator (as side effect we get InstructionReceptor).

https://codereview.chromium.org/2771753004/diff/1/courgette/instruction_utils.h
File courgette/instruction_utils.h (right):

https://codereview.chromium.org/2771753004/diff/1/courgette/instruction_utils...
courgette/instruction_utils.h:17: // An interface to receive emitted
instructions parsed from an executable.
InstructionReceptor identical to the code deleted from assembly_program.h.

https://codereview.chromium.org/2771753004/diff/1/courgette/instruction_utils...
courgette/instruction_utils.h:62: using InstructionGenerator =
base::Callback<CheckBool(InstructionReceptor*)>;
Compared to old code in assembly_program.h, removed AssemblyProgram* param.

[Will Harris, 2017-03-23 19:00:37]

lgtm

[huangs, 2017-03-23 20:49:21]

Thanks. Committing soon!

[huangs, 2017-03-23 20:49:28]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 20:50:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 21:00:02]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-03-23 21:00:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[huangs, 2017-03-23 22:07:20]

The CQ bit was checked by [email protected]

[huangs, 2017-03-23 22:07:21]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2771753004/#ps20001
(title: "Fix signed/unsigned comparison issue in test.")

[commit-bot: I haz the power, 2017-03-23 22:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:17:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490306840664360,
"parent_rev": "363c91c57a5ae99e63a138555afa83dc02262325", "commit_rev":
"257f9fb084fd9c3a660ef8d7fd2948cb3d3fd1fb"}

[commit-bot: I haz the power, 2017-03-23 23:19:02]

Description was changed from

==========
[Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate
AssemblyProgram there.

This is part of AssemblyProgram reduction effort. Details:
- Add Disassembler::Disassemble() and dedup separate PE/ELF versions.
  - Instantiate AssemblyProgram there; replaces old behavior where
    caller (program_detector.cc) instantiates and passes as out param.
- Add virtual Disassembler::GetInstructionGenerator().
  - Remove InstructionGenerator's AssemblyProgram* param; update tests.
- Move InstructionReceptor and InstructionGenerator from AssemblyProgram
  to new file instruction_utils.h.
- Rename ParseAbs32Relocs() to ExtractAbs32Locations(); make common.
- Rename ParseRel32Relocs() to ExtractRel32Locations(); make common.
- Make DisassemblerElf32::abs32_locations_ non-mutable.

BUG=660980
==========

to

==========
[Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate
AssemblyProgram there.

This is part of AssemblyProgram reduction effort. Details:
- Add Disassembler::Disassemble() and dedup separate PE/ELF versions.
  - Instantiate AssemblyProgram there; replaces old behavior where
    caller (program_detector.cc) instantiates and passes as out param.
- Add virtual Disassembler::GetInstructionGenerator().
  - Remove InstructionGenerator's AssemblyProgram* param; update tests.
- Move InstructionReceptor and InstructionGenerator from AssemblyProgram
  to new file instruction_utils.h.
- Rename ParseAbs32Relocs() to ExtractAbs32Locations(); make common.
- Rename ParseRel32Relocs() to ExtractRel32Locations(); make common.
- Make DisassemblerElf32::abs32_locations_ non-mutable.

BUG=660980

Review-Url: https://codereview.chromium.org/2771753004
Cr-Commit-Position: refs/heads/master@{#459272}
Committed:
https://chromium.googlesource.com/chromium/src/+/257f9fb084fd9c3a660ef8d7fd29...
==========

[commit-bot: I haz the power, 2017-03-23 23:19:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/257f9fb084fd9c3a660ef8d7fd29...