Prevent bookmarklet and unload tests from being broken by data URL deprecation.

Prevent bookmarklet and unload tests from being broken by data URL deprecation.

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215.

BUG=594215
Review-Url: https://codereview.chromium.org/2795903002
Cr-Commit-Position: refs/heads/master@{#461916}
Committed: https://chromium.googlesource.com/chromium/src/+/e91f49f4a95353dce39091e84376fc75787934f6

[meacer, 2017-04-03 23:34:35]

[email protected] changed reviewers:
+ [email protected]

[meacer, 2017-04-03 23:34:36]

nasko: PTAL?

[meacer, 2017-04-03 23:41:05]

Description was changed from

==========
Prevent bookmarklet tests from being broken by data URL deprecation.

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215.

BUG=594215
==========

to

==========
Prevent bookmarklet and unload tests from being broken by data URL deprecation.

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215.

BUG=594215
==========

[nasko, 2017-04-04 23:01:20]

https://codereview.chromium.org/2795903002/diff/40001/chrome/browser/unload_b...
File chrome/browser/unload_browsertest.cc (right):

https://codereview.chromium.org/2795903002/diff/40001/chrome/browser/unload_b...
chrome/browser/unload_browsertest.cc:42: const char NOLISTENERS_HTML[] =
Why the std::string -> char conversion?

[meacer, 2017-04-04 23:05:26]

https://codereview.chromium.org/2795903002/diff/40001/chrome/browser/unload_b...
File chrome/browser/unload_browsertest.cc (right):

https://codereview.chromium.org/2795903002/diff/40001/chrome/browser/unload_b...
chrome/browser/unload_browsertest.cc:42: const char NOLISTENERS_HTML[] =
On 2017/04/04 23:01:20, nasko wrote:
> Why the std::string -> char conversion?

According to the style guide, globals must be POD types:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

[nasko, 2017-04-04 23:09:28]

On 2017/04/04 23:05:26, Mustafa Emre Acer wrote:
>
https://codereview.chromium.org/2795903002/diff/40001/chrome/browser/unload_b...
> File chrome/browser/unload_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2795903002/diff/40001/chrome/browser/unload_b...
> chrome/browser/unload_browsertest.cc:42: const char NOLISTENERS_HTML[] =
> On 2017/04/04 23:01:20, nasko wrote:
> > Why the std::string -> char conversion?
> 
> According to the style guide, globals must be POD types:
> https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

LGTM

[meacer, 2017-04-04 23:10:17]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2017-04-04 23:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:34:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491347417964400,
"parent_rev": "4d9d2432508df3c21fec9178132362c52023dae2", "commit_rev":
"e91f49f4a95353dce39091e84376fc75787934f6"}

[commit-bot: I haz the power, 2017-04-05 00:36:15]

Description was changed from

==========
Prevent bookmarklet and unload tests from being broken by data URL deprecation.

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215.

BUG=594215
==========

to

==========
Prevent bookmarklet and unload tests from being broken by data URL deprecation.

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215.

BUG=594215

Review-Url: https://codereview.chromium.org/2795903002
Cr-Commit-Position: refs/heads/master@{#461916}
Committed:
https://chromium.googlesource.com/chromium/src/+/e91f49f4a95353dce39091e84376...
==========

[commit-bot: I haz the power, 2017-04-05 00:36:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e91f49f4a95353dce39091e84376...