Use test UUIDs for device bluetooth unit tests

Use test UUIDs for device bluetooth unit tests

This is a follow-up CL for:
https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc

This CL added some test characteristic and descriptor UUIDs to
bluetooth_test.h and updated device bluetooth unit tests to use them.

BUG=None

Review-Url: https://codereview.chromium.org/2798193002
Cr-Commit-Position: refs/heads/master@{#462946}
Committed: https://chromium.googlesource.com/chromium/src/+/5806cecba39a1ffb99c12a2f72829d82bf82b0f3

[juncai, 2017-04-05 23:30:22]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:31:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-04-05 23:31:24]

Description was changed from

==========
Use test UUIDs for device bluetooth unit tests

This is a follow-up CL for:
https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/blueto...

This CL added some test characteristic and descriptor UUIDs to
bluetooth_test.h and updated device bluetooth unit tests to use them

BUG=None
==========

to

==========
Use test UUIDs for device bluetooth unit tests

This is a follow-up CL for:
https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/blueto...

This CL added some test characteristic and descriptor UUIDs to
bluetooth_test.h and updated device bluetooth unit tests to use them.

BUG=None
==========

[commit-bot: I haz the power, 2017-04-06 00:46:40]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-04-06 00:46:40]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-04-06 00:47:17]

[email protected] changed reviewers:
+ [email protected]

[juncai, 2017-04-06 00:47:17]

Please take a look.

[ortuno, 2017-04-06 00:56:20]

yay! Thanks for the clean up! lgtm

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:1280:
services.push_back(kTestUUIDGenericAccess);
optional: We used push_back because initializer lists were not available then.
All new code uses initializer lists e.g. [1]. Since we are already changing the
UUIDs we might as well use initializer lists everywhere:

SimulateGattServicesDiscovered(
  device,
  std::vector<std::string>({kTestUUIDGenericAccess, kTestUUIDHeartRate}));


[1]
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_device_unitte...

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/test/bluet...
File device/bluetooth/test/bluetooth_test.cc (right):

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/test/bluet...
device/bluetooth/test/bluetooth_test.cc:28: const std::string
BluetoothTestBase::kTestUUIDGenericAccess =
nit: Add the following on top of the relevant UUIDs.

// Service UUIDs
// Characteristic UUIDs
// Descriptor UUIDs

[juncai, 2017-04-07 17:42:46]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:43:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:41:09]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-04-07 18:41:10]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-04-07 18:50:19]

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:1280:
services.push_back(kTestUUIDGenericAccess);
On 2017/04/06 00:56:19, ortuno wrote:
> optional: We used push_back because initializer lists were not available then.
> All new code uses initializer lists e.g. [1]. Since we are already changing
the
> UUIDs we might as well use initializer lists everywhere:
> 
> SimulateGattServicesDiscovered(
>   device,
>   std::vector<std::string>({kTestUUIDGenericAccess, kTestUUIDHeartRate}));
> 
> 
> [1]
>
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_device_unitte...

Done.

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/test/bluet...
File device/bluetooth/test/bluetooth_test.cc (right):

https://codereview.chromium.org/2798193002/diff/1/device/bluetooth/test/bluet...
device/bluetooth/test/bluetooth_test.cc:28: const std::string
BluetoothTestBase::kTestUUIDGenericAccess =
On 2017/04/06 00:56:20, ortuno wrote:
> nit: Add the following on top of the relevant UUIDs.
> 
> // Service UUIDs
> // Characteristic UUIDs
> // Descriptor UUIDs

Done.

[juncai, 2017-04-07 18:50:27]

The CQ bit was checked by [email protected]

[juncai, 2017-04-07 18:50:27]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2798193002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-04-07 18:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:59:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491591027147820,
"parent_rev": "b726dba11c90d226f70c9dae4de30c002c066131", "commit_rev":
"5806cecba39a1ffb99c12a2f72829d82bf82b0f3"}

[commit-bot: I haz the power, 2017-04-07 19:00:00]

Description was changed from

==========
Use test UUIDs for device bluetooth unit tests

This is a follow-up CL for:
https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/blueto...

This CL added some test characteristic and descriptor UUIDs to
bluetooth_test.h and updated device bluetooth unit tests to use them.

BUG=None
==========

to

==========
Use test UUIDs for device bluetooth unit tests

This is a follow-up CL for:
https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/blueto...

This CL added some test characteristic and descriptor UUIDs to
bluetooth_test.h and updated device bluetooth unit tests to use them.

BUG=None

Review-Url: https://codereview.chromium.org/2798193002
Cr-Commit-Position: refs/heads/master@{#462946}
Committed:
https://chromium.googlesource.com/chromium/src/+/5806cecba39a1ffb99c12a2f7282...
==========

[commit-bot: I haz the power, 2017-04-07 19:00:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5806cecba39a1ffb99c12a2f7282...