Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2851193002: cc: Rename LayerImpl::is_drawn_render_surface_layer_list_member (Closed)

Created:
3 years, 7 months ago by ajuma
Modified:
3 years, 7 months ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename LayerImpl::is_drawn_render_surface_layer_list_member Since there's no longer a render surface layer list, this renames LayerImpl::is_drawn_render_surface_layer_list_member to contributes_to_drawn_render_surface. BUG=611883 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2851193002 Cr-Commit-Position: refs/heads/master@{#468413} Committed: https://chromium.googlesource.com/chromium/src/+/651848a51fcc175e9a42f588efc3d7d138ccaa36

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -139 lines) Patch
M cc/layers/effect_tree_layer_list_iterator.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/debug_rect_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 19 chunks +76 lines, -77 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 9 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
ajuma
3 years, 7 months ago (2017-05-01 14:59:12 UTC) #5
jaydasika
lgtm https://codereview.chromium.org/2851193002/diff/1/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/2851193002/diff/1/cc/trees/layer_tree_host_common_unittest.cc#newcode10308 cc/trees/layer_tree_host_common_unittest.cc:10308: // mask isn't a drawn RSLL member. This ...
3 years, 7 months ago (2017-05-01 16:49:22 UTC) #10
ajuma
https://codereview.chromium.org/2851193002/diff/1/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/2851193002/diff/1/cc/trees/layer_tree_host_common_unittest.cc#newcode10308 cc/trees/layer_tree_host_common_unittest.cc:10308: // mask isn't a drawn RSLL member. This means ...
3 years, 7 months ago (2017-05-01 17:23:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851193002/20001
3 years, 7 months ago (2017-05-01 17:24:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/283205)
3 years, 7 months ago (2017-05-01 18:51:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851193002/40001
3 years, 7 months ago (2017-05-01 19:36:46 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:24:03 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/651848a51fcc175e9a42f588efc3...

Powered by Google App Engine
This is Rietveld 408576698