Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 2854793002: Remove redundant WebLocalFrame* parameter from DidCreateScriptContext (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 7 months ago
Reviewers:
kinuko, tkent, joelhockey
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from DidCreateScriptContext Remove redundant WebLocalFrame* parameter from DidCreateScriptContext in WebFrameClient. BUG=361765 Review-Url: https://codereview.chromium.org/2854793002 Cr-Commit-Position: refs/heads/master@{#468810} Committed: https://chromium.googlesource.com/chromium/src/+/7dbeb111501e1b9e0a73ea84a96086442b3ae98e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
sashab
3 years, 7 months ago (2017-05-02 05:30:01 UTC) #2
joelhockey
lgtm
3 years, 7 months ago (2017-05-02 05:30:45 UTC) #5
sashab
kinuko content/, tkent webkit/ tyvm :)
3 years, 7 months ago (2017-05-02 05:36:16 UTC) #7
kinuko
lgtm (for webkit too)
3 years, 7 months ago (2017-05-02 07:10:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854793002/1
3 years, 7 months ago (2017-05-02 23:07:43 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:13:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7dbeb111501e1b9e0a73ea84a960...

Powered by Google App Engine
This is Rietveld 408576698