Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855813002:
[CrOS Tether] Integrate the tether connection dialog with the settings page. (Closed)
|
Created:
3 years, 7 months ago by Kyle Horimoto Modified:
3 years, 7 months ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, Ryan Hansberry, James Hawkins, lesliewatkins Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[CrOS Tether] Integrate the tether connection dialog with the settings page.
When attempting to connect to a Tether network, the settings page will now display a confirmation dialog if the user has not yet connected to this device.
BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2855813002
Cr-Commit-Position: refs/heads/master@{#468786}
Committed: https://chromium.googlesource.com/chromium/src/+/33dd9a282e6918138ab3c6f76ca16bc0a3ae333b
Patch Set 1 #
Total comments: 31
Patch Set 2 : stevenjb@ comments. #
Total comments: 10
Patch Set 3 : stevenjb@ comments. #
Total comments: 4
Messages
Total messages: 15 (6 generated)
Description was changed from ========== [CrOS Tether] Integrate the tether connection dialog with the settings page. When attempting to connect to a Tether network, the settings page will now display a confirmation dialog if the user has not yet connected to this device. BUG=672263 ========== to ========== [CrOS Tether] Integrate the tether connection dialog with the settings page. When attempting to connect to a Tether network, the settings page will now display a confirmation dialog if the user has not yet connected to this device. BUG=672263 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
[email protected] changed reviewers: + [email protected]
https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:142: 'tetherDialog.connect-tap': 'onTetherDialogConnectTap_', 'connect-tap' is a little confusing, normally we would handle a 'tap' within the HTML. This event is fired by the tether dialog (it just happens to be triggered by a tap). We should name this something like 'tether-connect' and name the handler appropriately (onTetherConnect_). Also, this can be inlined in the HTML; <tether-connection-dialog ... on-tether-connect="[[onTetherConnect_]]"> For events associated with a single element, inlining the handler in the HTML is more common. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:156: * This boolean is set in currentRouteChanged() if the showTetherDialog URL nit: s/This boolean is set in/Set in/ (It's already declared as a {boolean}). https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:240: && !!this.networkProperties.Tether) { nit: !! not required here. It's only required when setting or returning a boolean type. Also, it's better to check networkPropertues.Type == CrOnc.Type.TETHER. It would be valid in ONC to have a Tether network with no .Tether properties set (and no .Tether object), especially for a never connected network which will not have any state properties. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:248: if (!button) We should focus the dialog button in showTetherDialog_ instead. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:568: } Could you try the following: * Fire 'network-connect' here and in internet_subpage.js. * And a listener to 'network-connect' in internet_page.js. * Move the code you added to connectToNetwork_ in internet_subpage.js to the handler in internet_page.js. Then we only have one place where we call either show the dialog or call this.networkingPrivate.startConnect(). My only concern is whether or not there will be any flicker if we call settings.navigateTo(settings.Route.NETWORK_DETAIL, params) from the detail page, but I don't -think- there should be. If there is, we could check the current route and call showTetherDialog() in the detail page from internet_page.js directly. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/tether_connection_dialog.html (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.html:68: on-tap="onConnectTap_"> combine lines https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/tether_connection_dialog.js (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:42: }, This shouldn't be needed if we focus the connect button from showTetherDialog in the detail page. Actually, it might be better to focus it here in open(). https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:59: }, We shouldn't need this, see comments below. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:96: * @param {!CrOnc.NetworkProperties|undefined} networkProperties The network This will always be defined when this is called. Polymer data binding only calls methods when all declared parameters are defined. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:103: ? CrOnc.getNetworkName(networkProperties) : ''; This can just be CrOnc.getNetworkName(networkProperties) since networkProperties will always be defined. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:108: * properties. no |undefined https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:116: : ''; var percentage = this.get('Tether.BatteryPercentage', this.networkProperties); if (percentage === undefined) return ''; return this.i18n('tetherConnectionBatteryPercentage', percentage.toString()); Even if this.networkProperties.Tether is defined, BatteryPercentage may not be. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:120: * @param {!CrOnc.NetworkProperties|undefined} networkProperties The network no |undefined https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:138: this.hasValidTetherProperties_(networkProperties) not needed https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:152: : ''); See above. Also I would move the common code to a getBatteryPercentageString_ helper.
https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:142: 'tetherDialog.connect-tap': 'onTetherDialogConnectTap_', On 2017/05/02 16:35:59, stevenjb wrote: > 'connect-tap' is a little confusing, normally we would handle a 'tap' within the > HTML. This event is fired by the tether dialog (it just happens to be triggered > by a tap). We should name this something like 'tether-connect' and name the > handler appropriately (onTetherConnect_). > > Also, this can be inlined in the HTML; > > <tether-connection-dialog ... on-tether-connect="[[onTetherConnect_]]"> > > For events associated with a single element, inlining the handler in the HTML is > more common. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:156: * This boolean is set in currentRouteChanged() if the showTetherDialog URL On 2017/05/02 16:35:59, stevenjb wrote: > nit: s/This boolean is set in/Set in/ (It's already declared as a {boolean}). > Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:240: && !!this.networkProperties.Tether) { On 2017/05/02 16:35:59, stevenjb wrote: > nit: !! not required here. It's only required when setting or returning a > boolean type. > > Also, it's better to check networkPropertues.Type == CrOnc.Type.TETHER. It would > be valid in ONC to have a Tether network with no .Tether properties set (and no > .Tether object), especially for a never connected network which will not have > any state properties. I removed the !! as you suggested. However, I don't think that the second suggestion is the correct thing to do. We only want to display the dialog if we do have a .Tether property set; if we do not have a .Tether property, we do not have the information (e.g., battery percentage) to display in the text of the dialog. We will always have this information, even if we have never connected to the network before (remember, these parameters need to be passed to NSH::AddTetherNetworkState()). Note that we do set this.networkProperties to an Object without a .Tether field in currentRouteChanged(), but that is only until the real properties have been loaded. I don't think we should show the dialog until the real properties have been loaded to prevent a flash of the dialog text once the values load. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:248: if (!button) On 2017/05/02 16:35:59, stevenjb wrote: > We should focus the dialog button in showTetherDialog_ instead. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:568: } On 2017/05/02 16:35:59, stevenjb wrote: > Could you try the following: > * Fire 'network-connect' here and in internet_subpage.js. > * And a listener to 'network-connect' in internet_page.js. > * Move the code you added to connectToNetwork_ in internet_subpage.js to the > handler in internet_page.js. > > Then we only have one place where we call either show the dialog or call > this.networkingPrivate.startConnect(). > > My only concern is whether or not there will be any flicker if we call > settings.navigateTo(settings.Route.NETWORK_DETAIL, params) from the detail page, > but I don't -think- there should be. If there is, we could check the current > route and call showTetherDialog() in the detail page from internet_page.js > directly. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/tether_connection_dialog.html (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.html:68: on-tap="onConnectTap_"> On 2017/05/02 16:35:59, stevenjb wrote: > combine lines Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/tether_connection_dialog.js (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:42: }, On 2017/05/02 16:36:00, stevenjb wrote: > This shouldn't be needed if we focus the connect button from showTetherDialog in > the detail page. > > Actually, it might be better to focus it here in open(). Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:59: }, On 2017/05/02 16:36:00, stevenjb wrote: > We shouldn't need this, see comments below. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:96: * @param {!CrOnc.NetworkProperties|undefined} networkProperties The network On 2017/05/02 16:36:00, stevenjb wrote: > This will always be defined when this is called. Polymer data binding only calls > methods when all declared parameters are defined. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:103: ? CrOnc.getNetworkName(networkProperties) : ''; On 2017/05/02 16:36:00, stevenjb wrote: > This can just be CrOnc.getNetworkName(networkProperties) since > networkProperties will always be defined. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:108: * properties. On 2017/05/02 16:35:59, stevenjb wrote: > no |undefined Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:116: : ''; On 2017/05/02 16:36:00, stevenjb wrote: > var percentage = this.get('Tether.BatteryPercentage', this.networkProperties); > if (percentage === undefined) > return ''; > return this.i18n('tetherConnectionBatteryPercentage', percentage.toString()); > > Even if this.networkProperties.Tether is defined, BatteryPercentage may not be. Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:120: * @param {!CrOnc.NetworkProperties|undefined} networkProperties The network On 2017/05/02 16:36:00, stevenjb wrote: > no |undefined Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:138: this.hasValidTetherProperties_(networkProperties) On 2017/05/02 16:36:00, stevenjb wrote: > not needed Done. https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:152: : ''); On 2017/05/02 16:35:59, stevenjb wrote: > See above. Also I would move the common code to a getBatteryPercentageString_ > helper. Done.
lgtm https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/internet_page/internet_detail_page.js:240: && !!this.networkProperties.Tether) { On 2017/05/02 18:58:27, Kyle Horimoto wrote: > On 2017/05/02 16:35:59, stevenjb wrote: > > nit: !! not required here. It's only required when setting or returning a > > boolean type. > > > > Also, it's better to check networkPropertues.Type == CrOnc.Type.TETHER. It > would > > be valid in ONC to have a Tether network with no .Tether properties set (and > no > > .Tether object), especially for a never connected network which will not have > > any state properties. > > I removed the !! as you suggested. > > However, I don't think that the second suggestion is the correct thing to do. We > only want to display the dialog if we do have a .Tether property set; if we do > not have a .Tether property, we do not have the information (e.g., battery > percentage) to display in the text of the dialog. We will always have this > information, even if we have never connected to the network before (remember, > these parameters need to be passed to NSH::AddTetherNetworkState()). > > Note that we do set this.networkProperties to an Object without a .Tether field > in currentRouteChanged(), but that is only until the real properties have been > loaded. I don't think we should show the dialog until the real properties have > been loaded to prevent a flash of the dialog text once the values load. I prefer avoiding baking in too many assumptions about the current implementation into the UI. Strictly speaking, the presence of the Tether object does not dictate the type, so we should at least test that explicitly. It is also possible for any Tether members to be undefined, so we should handle that gracefully regardless. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:170: * @param {!settings.Route|undefined} opt_oldRoute Technically either |route| or |oldRoute| might be undefined (definition is in route.js). I would just call this oldRoute. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:259: // overriding the focus code above. This note isn't really necessary. Every dialog should focus the correct element when opened. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:586: // includes a query parameter of "showTetherDialog=true". If the previous nit: this is a little confusing. How about something like: The tether dialog is opened by specifying "showTetherDialog=true" in the query params. This may lead to the previous route also being the detail page, in which case we should navigate back to the previous route here so that when the user navigates back they will navigate to the previous non detail page. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/internet_page.js (right): https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_page.js:402: && !event.detail.bypassConnectionDialog) { nit: Test event.detail.bypassConnectionDialog first since it's a simpler test. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/tether_connection_dialog.js (right): https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:57: //this.fire('tether-cancel'); elim?
https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:170: * @param {!settings.Route|undefined} opt_oldRoute On 2017/05/02 19:43:21, stevenjb wrote: > Technically either |route| or |oldRoute| might be undefined (definition is in > route.js). I would just call this oldRoute. Done. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:259: // overriding the focus code above. On 2017/05/02 19:43:21, stevenjb wrote: > This note isn't really necessary. Every dialog should focus the correct element > when opened. Done. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:586: // includes a query parameter of "showTetherDialog=true". If the previous On 2017/05/02 19:43:21, stevenjb wrote: > nit: this is a little confusing. How about something like: > > The tether dialog is opened by specifying "showTetherDialog=true" in the query > params. This may lead to the previous route also being the detail page, in which > case we should navigate back to the previous route here so that when the user > navigates back they will navigate to the previous non detail page. Done. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/internet_page.js (right): https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_page.js:402: && !event.detail.bypassConnectionDialog) { On 2017/05/02 19:43:21, stevenjb wrote: > nit: Test event.detail.bypassConnectionDialog first since it's a simpler test. Done. https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/tether_connection_dialog.js (right): https://codereview.chromium.org/2855813002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/tether_connection_dialog.js:57: //this.fire('tether-cancel'); On 2017/05/02 19:43:21, stevenjb wrote: > elim? Done.
The CQ bit was checked by [email protected]
The patchset sent to the CQ was uploaded after l-g-t-m from [email protected] Link to the patchset: https://codereview.chromium.org/2855813002/#ps40001 (title: "stevenjb@ comments.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
just some drive-by tips https://codereview.chromium.org/2855813002/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:156: * @private btw, @private {boolean} is the same but shorter https://codereview.chromium.org/2855813002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:257: && this.networkProperties.Tether) { btw, unless clang-format does this for you, i'd recommend sticking to && at the end also, you can run `git cl format --js` and it'll automatically touch up your CL
https://codereview.chromium.org/2855813002/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2855813002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:156: * @private On 2017/05/02 21:07:10, Dan Beam wrote: > btw, @private {boolean} is the same but shorter Thanks. Is this preferred? I actually used this originally, but I noticed that most other use cases use both @type and @private on separate lines. https://codereview.chromium.org/2855813002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/internet_page/internet_detail_page.js:257: && this.networkProperties.Tether) { On 2017/05/02 21:07:10, Dan Beam wrote: > btw, unless clang-format does this for you, i'd recommend sticking to && at the > end > > also, you can run `git cl format --js` and it'll automatically touch up your CL Acknowledged.
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493758140534450,
"parent_rev": "00ef929f434505f4d09a130e0bc1d4a4938d490f", "commit_rev":
"33dd9a282e6918138ab3c6f76ca16bc0a3ae333b"}
Message was sent while issue was closed.
Description was changed from ========== [CrOS Tether] Integrate the tether connection dialog with the settings page. When attempting to connect to a Tether network, the settings page will now display a confirmation dialog if the user has not yet connected to this device. BUG=672263 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [CrOS Tether] Integrate the tether connection dialog with the settings page. When attempting to connect to a Tether network, the settings page will now display a confirmation dialog if the user has not yet connected to this device. BUG=672263 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2855813002 Cr-Commit-Position: refs/heads/master@{#468786} Committed: https://chromium.googlesource.com/chromium/src/+/33dd9a282e6918138ab3c6f76ca1... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/33dd9a282e6918138ab3c6f76ca1... |
