Use constexpr TaskTraits constructor in content.

Use constexpr TaskTraits constructor in content.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG=713683
[email protected]
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2857983003
Cr-Commit-Position: refs/heads/master@{#469433}
Committed: https://chromium.googlesource.com/chromium/src/+/27b0b2aa98566217498c58e9174da2c6789cd433

[fdoray, 2017-05-03 20:21:32]

The CQ bit was checked by [email protected] to run a CQ dry run

[fdoray, 2017-05-03 20:21:33]

Description was changed from

==========
Use constexpr TaskTraits constructor in content.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG=713683
[email protected]
[email protected]
==========

to

==========
Use constexpr TaskTraits constructor in content.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG=713683
[email protected]
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[fdoray, 2017-05-03 20:21:35]

gab@: PTAL

The change will then be TBRed to the owner.

[commit-bot: I haz the power, 2017-05-03 20:22:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 20:25:59]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-05-03 20:26:00]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[gab, 2017-05-04 14:09:02]

lgtm

https://codereview.chromium.org/2857983003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2857983003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:1014: constexpr base::TaskTraits
kUserVisibleTraits = {
// Note: if you're copying these TaskTraits elsewhere, you most likely don't
need and shouldn't use base::WithBaseSyncPrimitives() -- see its documentation.

[fdoray, 2017-05-04 18:50:39]

https://codereview.chromium.org/2857983003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2857983003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:1014: constexpr base::TaskTraits
kUserVisibleTraits = {
On 2017/05/04 14:09:02, gab wrote:
> // Note: if you're copying these TaskTraits elsewhere, you most likely don't
> need and shouldn't use base::WithBaseSyncPrimitives() -- see its
documentation.

Done.

[fdoray, 2017-05-04 18:50:45]

The CQ bit was checked by [email protected]

[fdoray, 2017-05-04 18:50:46]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2857983003/#ps20001
(title: "CR gab #8")

[commit-bot: I haz the power, 2017-05-04 18:51:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 19:52:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493923845896160,
"parent_rev": "d3e08ca678225b65a89c91f01329ecc11ef8b554", "commit_rev":
"27b0b2aa98566217498c58e9174da2c6789cd433"}

[commit-bot: I haz the power, 2017-05-04 19:52:28]

Description was changed from

==========
Use constexpr TaskTraits constructor in content.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG=713683
[email protected]
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Use constexpr TaskTraits constructor in content.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG=713683
[email protected]
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2857983003
Cr-Commit-Position: refs/heads/master@{#469433}
Committed:
https://chromium.googlesource.com/chromium/src/+/27b0b2aa98566217498c58e9174d...
==========

[commit-bot: I haz the power, 2017-05-04 19:52:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27b0b2aa98566217498c58e9174d...