Asynchronously open the temp file used for Pepper StreamToFile, and delete th...

Asynchronously open the temp file used for Pepper StreamToFile, and delete the
temp file once we are done with it.

We observe ResourceHandle::OnRequestClosed as a signal of when we should delete
the temp file.  This corresponds to the WebURLLoader being closed (or
canceled).

This patch also includes some helpers:

base/scoped_callback_factory.h
  This class makes it easy to allocate Callbacks that hold a weak reference
  back to the owning class.  It works just like ScopedRunnableMethodFactory
  but for Callbacks instead of RunnableMethods.

base/platform_file.h
  Added a PassPlatformFile class that is useful for cases where a callback may
  decide not to take ownership of a PlatformFile (as can happen when using
  ScopedCallbackFactory).

chrome/file_system_proxy.{h,cc}
  This class provides static methods for executing file system commands on the
  FILE thread.  It routes callbacks back to the originating thread to deliver
  results (file handles, etc.).  Note: this file declares a few functions that
  are not yet used.  I anticipate that we'll make use of these and add more
  functions here to support the Pepper and OWP FileSystem APIs.

chrome/chrome_thread_relay.{h,cc}
  This class is a helper class for proxying calls over to a background
  ChromeThread and then returning results to the originating ChromeThread.

R=brettw
BUG=49789
TEST=(more to be added in third_party/ppapi/tests)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54402

[darin (slow to review), 2010-07-29 05:51:45]

Note: I plan on making use of FileSystemProxy to reduce some complexity in
ResourceMessageFilter as a follow-up CL.

[darin (slow to review), 2010-07-29 07:37:10]

I think I'm going to redo this without the browser/base/ directory since it
seems
like that is somewhat contentious.

-Darin


On Wed, Jul 28, 2010 at 4:57 PM, <[email protected]> wrote:

> Reviewers: brettw,
>
> Description:
> Asynchronously open the temp file used for Pepper StreamToFile, and delete
> the
> temp file once we are done with it.
>
> We observe ResourceHandle::OnRequestClosed as a signal of when we should
> delete
> the temp file.  This corresponds to the WebURLLoader being closed (or
> canceled).
>
> This patch also includes some helpers:
>
> base/scoped_callback_factory.h
>  This class makes it easy to allocate Callbacks that hold a weak reference
>  back to the owning class.  It works just like ScopedRunnableMethodFactory
>  but for Callbacks instead of RunnableMethods.
>
> chrome/base/file_system_proxy.{h,cc}
>  This class provides static methods for executing file system commands on
> the
>  FILE thread.  It routes callbacks back to the originating thread to
> deliver
>  results (file handles, etc.).  Note: this file declares a few functions
> that
>  are not yet used.  I anticipate that we'll make use of these and add more
>  functions here to support the Pepper and OWP FileSystem APIs.
>
> chrome/base/chrome_thread_relay.{h,cc}
>  This class is a helper class for proxying calls over to a background
>  ChromeThread and then returning results to the originating ChromeThread.
>
> R=brettw
> BUG=49789
> TEST=none (more needed)
>
>
> Please review this at http://codereview.chromium.org/2878062/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/base.gypi
>  A     base/scoped_callback_factory.h
>  A     chrome/browser/base/chrome_thread_relay.h
>  A     chrome/browser/base/chrome_thread_relay.cc
>  A     chrome/browser/base/file_system_proxy.h
>  A     chrome/browser/base/file_system_proxy.cc
>  M     chrome/browser/renderer_host/redirect_to_file_resource_handler.h
>  M     chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
>  M     chrome/chrome_browser.gypi
>
>
>

[brettw, 2010-07-30 16:43:01]

LGTM

http://codereview.chromium.org/2878062/diff/13004/29003
File base/platform_file.h (right):

http://codereview.chromium.org/2878062/diff/13004/29003#newcode63
base/platform_file.h:63: //  void MaybeProcessFile(PassPlatformFile
platform_file);
This took me a while of staring at it to figure out. Can you add in your example
here in MaybeProcessFile that it calls ReleaseValue() to get the handle out and
use it. Can you also add a comment above ReleaseValue about what it does and how
it marks the handle as "released"?

[darin (slow to review), 2010-07-30 17:07:06]

On Fri, Jul 30, 2010 at 9:43 AM, <[email protected]> wrote:

> LGTM
>
>
> http://codereview.chromium.org/2878062/diff/13004/29003
> File base/platform_file.h (right):
>
> http://codereview.chromium.org/2878062/diff/13004/29003#newcode63
> base/platform_file.h:63: //  void MaybeProcessFile(PassPlatformFile
> platform_file);
> This took me a while of staring at it to figure out. Can you add in your
> example here in MaybeProcessFile that it calls ReleaseValue() to get the
> handle out and use it. Can you also add a comment above ReleaseValue
> about what it does and how it marks the handle as "released"?



Good idea.  It took me a while to settle on this approach.  I hope it won't
be too complicated for users.

Thanks for the review!

-Darin


>
>
> http://codereview.chromium.org/2878062/show
>