[Offline Prefetch] Backoff support for PrefetchBackgroundTask

[Offline Prefetch] Backoff support for PrefetchBackgroundTask

Make PrefetchBackgroundTask support exponential backoff which is saved
to prefs store.

BUG=727905
TEST=new tests

Review-Url: https://codereview.chromium.org/2914703002
Cr-Commit-Position: refs/heads/master@{#477553}
Committed: https://chromium.googlesource.com/chromium/src/+/ac940cb6160ade6899f326ddde2d180b14e02f4f

[jianli, 2017-05-30 21:48:51]

The CQ bit was checked by [email protected] to run a CQ dry run

[jianli, 2017-05-30 21:48:58]

[email protected] changed reviewers:
+ [email protected]

[commit-bot: I haz the power, 2017-05-30 21:49:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 22:00:04]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-05-30 22:00:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jianli, 2017-05-30 22:11:34]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 22:12:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 22:21:36]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-05-30 22:21:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dewittj, 2017-05-31 21:33:34]

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc
(right):

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc:45:
-1,
Is "discard" even relevant to us?  Can you document if it isn't?

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h
(right):

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h:45:
void SignalTaskFinished(JNIEnv* env,
Please rename to SignalTaskFinishedForTesting, since this appears to be unused
in real code and is confusingly redundant with OnStopTask

https://codereview.chromium.org/2914703002/diff/20001/components/offline_page...
File components/offline_pages/core/prefetch/prefetch_dispatcher.h (right):

https://codereview.chromium.org/2914703002/diff/20001/components/offline_page...
components/offline_pages/core/prefetch/prefetch_dispatcher.h:73: virtual void
StopBackgroundTask(bool signaled_by_system) = 0;
Instead of signaled_by_system, can you please have a
RequestFinishBackgroundTaskForTest() that can be used in testing? Otherwise the
parameter implies functionality that just doesn't exist in the production
system.

[jianli, 2017-06-01 00:10:00]

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc
(right):

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc:45:
-1,
On 2017/05/31 21:33:33, dewittj wrote:
> Is "discard" even relevant to us?  Can you document if it isn't?

Done.

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h
(right):

https://codereview.chromium.org/2914703002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h:45:
void SignalTaskFinished(JNIEnv* env,
On 2017/05/31 21:33:33, dewittj wrote:
> Please rename to SignalTaskFinishedForTesting, since this appears to be unused
> in real code and is confusingly redundant with OnStopTask

Done.

https://codereview.chromium.org/2914703002/diff/20001/components/offline_page...
File components/offline_pages/core/prefetch/prefetch_dispatcher.h (right):

https://codereview.chromium.org/2914703002/diff/20001/components/offline_page...
components/offline_pages/core/prefetch/prefetch_dispatcher.h:73: virtual void
StopBackgroundTask(bool signaled_by_system) = 0;
On 2017/05/31 21:33:33, dewittj wrote:
> Instead of signaled_by_system, can you please have a
> RequestFinishBackgroundTaskForTest() that can be used in testing? Otherwise
the
> parameter implies functionality that just doesn't exist in the production
> system.

Done.

[dewittj, 2017-06-01 00:22:27]

lgtm

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc
(right):

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc:120:
Schedule(0);
Should we always Schedule(0) instead of sometimes returning false and sometimes
true?

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h
(right):

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h:41:
void SetTaskRescheduling(JNIEnv* env,
also ForTesting

https://codereview.chromium.org/2914703002/diff/40001/components/offline_page...
File components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc (right):

https://codereview.chromium.org/2914703002/diff/40001/components/offline_page...
components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc:53: if
(!task_)
Should this be DCHECK(task_) ?

[jianli, 2017-06-02 00:48:37]

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc
(right):

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc:120:
Schedule(0);
On 2017/06/01 00:22:27, dewittj wrote:
> Should we always Schedule(0) instead of sometimes returning false and
sometimes
> true?

Done.

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h
(right):

https://codereview.chromium.org/2914703002/diff/40001/chrome/browser/android/...
chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h:41:
void SetTaskRescheduling(JNIEnv* env,
On 2017/06/01 00:22:27, dewittj wrote:
> also ForTesting

Done.

https://codereview.chromium.org/2914703002/diff/40001/components/offline_page...
File components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc (right):

https://codereview.chromium.org/2914703002/diff/40001/components/offline_page...
components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc:53: if
(!task_)
On 2017/06/01 00:22:27, dewittj wrote:
> Should this be DCHECK(task_) ?

Done.

[jianli, 2017-06-02 00:54:35]

[email protected] changed reviewers:
+ [email protected], [email protected]

[jianli, 2017-06-02 00:54:35]

nyquist for background_scheduler
bauerb  for browser_prefs and webui

[jianli, 2017-06-02 00:54:50]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 00:55:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:07:17]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-06-02 01:07:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Bernhard Bauer, 2017-06-02 10:20:03]

LGTM

https://codereview.chromium.org/2914703002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
(right):

https://codereview.chromium.org/2914703002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:50:
static class TestPrefetchBackgroundTask extends PrefetchBackgroundTask {
Can you make the class private?

https://codereview.chromium.org/2914703002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:102:
super();
The super call is implicit.

[jianli, 2017-06-02 19:09:27]

https://codereview.chromium.org/2914703002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
(right):

https://codereview.chromium.org/2914703002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:50:
static class TestPrefetchBackgroundTask extends PrefetchBackgroundTask {
On 2017/06/02 10:20:03, Bernhard Bauer wrote:
> Can you make the class private?

Done.

https://codereview.chromium.org/2914703002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:102:
super();
On 2017/06/02 10:20:03, Bernhard Bauer wrote:
> The super call is implicit.

Done.

[nyquist, 2017-06-02 19:14:34]

https://codereview.chromium.org/2914703002/diff/100001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
(right):

https://codereview.chromium.org/2914703002/diff/100001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:101:
public TestBackgroundTaskScheduler() {}
Could this test instead have an empty implementation of
BackgroundTaskSchedulerDelegate? 

Something like:

private static NoopBackgroundTaskSchedulerDelegate implements
BackgroundTaskSchedulerDelegate {
    boolean schedule(Context context, TaskInfo taskInfo) { return true; }

    void cancel(Context context, int taskId) {}
}

And then just pass that along in this constructor?

[jianli, 2017-06-02 20:02:43]

https://codereview.chromium.org/2914703002/diff/100001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
(right):

https://codereview.chromium.org/2914703002/diff/100001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:101:
public TestBackgroundTaskScheduler() {}
On 2017/06/02 19:14:34, nyquist (nychthemeron ping) wrote:
> Could this test instead have an empty implementation of
> BackgroundTaskSchedulerDelegate? 
> 
> Something like:
> 
> private static NoopBackgroundTaskSchedulerDelegate implements
> BackgroundTaskSchedulerDelegate {
>     boolean schedule(Context context, TaskInfo taskInfo) { return true; }
> 
>     void cancel(Context context, int taskId) {}
> }
> 
> And then just pass that along in this constructor?

I can do this, but I need to make BackgroundTaskSchedulerDelegate public. If
you're fine with this, I will make the change.

[jianli, 2017-06-02 20:37:39]

https://codereview.chromium.org/2914703002/diff/100001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
(right):

https://codereview.chromium.org/2914703002/diff/100001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java:101:
public TestBackgroundTaskScheduler() {}
On 2017/06/02 20:02:43, jianli wrote:
> On 2017/06/02 19:14:34, nyquist (nychthemeron ping) wrote:
> > Could this test instead have an empty implementation of
> > BackgroundTaskSchedulerDelegate? 
> > 
> > Something like:
> > 
> > private static NoopBackgroundTaskSchedulerDelegate implements
> > BackgroundTaskSchedulerDelegate {
> >     boolean schedule(Context context, TaskInfo taskInfo) { return true; }
> > 
> >     void cancel(Context context, int taskId) {}
> > }
> > 
> > And then just pass that along in this constructor?
> 
> I can do this, but I need to make BackgroundTaskSchedulerDelegate public. If
> you're fine with this, I will make the change.

Updated per our discussion.

[nyquist, 2017-06-02 20:43:54]

lgtm. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=729156 for the
follow up from our discussion.

[jianli, 2017-06-02 21:37:29]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:38:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-06-02 21:52:24]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:53:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-06-02 21:53:19]

[email protected] changed reviewers:
+ [email protected]

[jianli, 2017-06-02 21:53:19]

thestig for chrome/common/DEPS

[Lei Zhang, 2017-06-02 21:56:25]

lgtm

[commit-bot: I haz the power, 2017-06-03 02:27:11]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-06-03 02:27:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jianli, 2017-06-05 21:32:34]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 21:33:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 21:37:47]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-06-05 21:37:48]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jianli, 2017-06-05 23:13:36]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:14:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:18:40]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-06-06 04:18:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jianli, 2017-06-06 23:18:06]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 23:20:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-06-07 00:23:05]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 00:23:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 01:45:37]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2017-06-07 01:45:38]

Dry run: This issue passed the CQ dry run.

[jianli, 2017-06-07 05:07:39]

The CQ bit was checked by [email protected]

[jianli, 2017-06-07 05:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected], [email protected], [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/2914703002/#ps220001
(title: "Fix test")

[commit-bot: I haz the power, 2017-06-07 05:07:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 05:13:10]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1496812059467160,
"parent_rev": "74cebf8fa0ca74a031087dd017cd04c8205b7c0c", "commit_rev":
"ac940cb6160ade6899f326ddde2d180b14e02f4f"}

[commit-bot: I haz the power, 2017-06-07 05:13:20]

Description was changed from

==========
[Offline Prefetch] Backoff support for PrefetchBackgroundTask

Make PrefetchBackgroundTask support exponential backoff which is saved
to prefs store.

BUG=727905
TEST=new tests
==========

to

==========
[Offline Prefetch] Backoff support for PrefetchBackgroundTask

Make PrefetchBackgroundTask support exponential backoff which is saved
to prefs store.

BUG=727905
TEST=new tests

Review-Url: https://codereview.chromium.org/2914703002
Cr-Commit-Position: refs/heads/master@{#477553}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac940cb6160ade6899f326ddde2d...
==========

[commit-bot: I haz the power, 2017-06-07 05:13:21]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/ac940cb6160ade6899f326ddde2d...