Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources.

Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources.

This makes TestFeaturesNativeHandler less Chrome-specific.
Also add more const to FeatureProvider.

Remove common_resources.h from extensions DEPS.

BUG=368334
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272097

[Yoyo Zhou, 2014-05-20 01:49:34]

https://codereview.chromium.org/293943002/diff/1/extensions/test/test_extensi...
File extensions/test/test_extensions_client.h (left):

https://codereview.chromium.org/293943002/diff/1/extensions/test/test_extensi...
extensions/test/test_extensions_client.h:20: virtual const PermissionsProvider&
GetPermissionsProvider() const OVERRIDE;
This was missed in a previous refactoring because extensions_unittests doesn't
compile on the trybots. =/

[James Cook, 2014-05-20 18:15:47]

LGTM with a nit on a comment

https://codereview.chromium.org/293943002/diff/1/chrome/common/extensions/chr...
File chrome/common/extensions/chrome_extensions_client.cc (right):

https://codereview.chromium.org/293943002/diff/1/chrome/common/extensions/chr...
chrome/common/extensions/chrome_extensions_client.cc:122:
ChromeExtensionsClient::CreateFeatureProviderSource(
btw, I like how you've introduced this API - nice separation of feature provider
vs. resource loading.

https://codereview.chromium.org/293943002/diff/1/extensions/DEPS
File extensions/DEPS (left):

https://codereview.chromium.org/293943002/diff/1/extensions/DEPS#oldcode16
extensions/DEPS:16: "!grit/common_resources.h",
Hooray!

https://codereview.chromium.org/293943002/diff/1/extensions/common/extensions...
File extensions/common/extensions_client.h (right):

https://codereview.chromium.org/293943002/diff/1/extensions/common/extensions...
extensions/common/extensions_client.h:53: // e.g. "permission". (There are
currently no other sources of features data.)
Doesn't this also work for "api" and "manifest"?  At least the
ShellExtensionsClient works for those.

https://codereview.chromium.org/293943002/diff/1/extensions/test/test_extensi...
File extensions/test/test_extensions_client.h (left):

https://codereview.chromium.org/293943002/diff/1/extensions/test/test_extensi...
extensions/test/test_extensions_client.h:20: virtual const PermissionsProvider&
GetPermissionsProvider() const OVERRIDE;
On 2014/05/20 01:49:34, Yoyo Zhou wrote:
> This was missed in a previous refactoring because extensions_unittests doesn't
> compile on the trybots. =/

I think tfarina addressed this in https://codereview.chromium.org/294483003/ so
you guys will be in a race to land/rebase. :-)

[Yoyo Zhou, 2014-05-21 01:05:47]

https://codereview.chromium.org/293943002/diff/1/extensions/common/extensions...
File extensions/common/extensions_client.h (right):

https://codereview.chromium.org/293943002/diff/1/extensions/common/extensions...
extensions/common/extensions_client.h:53: // e.g. "permission". (There are
currently no other sources of features data.)
On 2014/05/20 18:15:47, James Cook wrote:
> Doesn't this also work for "api" and "manifest"?  At least the
> ShellExtensionsClient works for those.

This wording is confusing. I'll fix it.

[Yoyo Zhou, 2014-05-21 01:05:53]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-05-21 01:07:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/293943002/20001

[commit-bot: I haz the power, 2014-05-21 09:14:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to [email protected].
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-21 09:17:18]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-05-21 09:17:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Yoyo Zhou, 2014-05-21 20:52:41]

TBR sky for OWNERS for a couple of refactoring changes

[Yoyo Zhou, 2014-05-21 20:52:46]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-05-21 20:55:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/293943002/40001

[commit-bot: I haz the power, 2014-05-22 04:27:43]

Change committed as 272097