Issue 29683002: Revert 229235 "Move the tab-lifetime handling functionality out ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 29683002: Revert 229235 "Move the tab-lifetime handling functionality out ..." (Closed)

Created:
7 years, 2 months ago by not at google - send to devlin

Modified:
7 years, 2 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 229235 "Move the tab-lifetime handling functionality out ..." No longer needed and it adds complexity, so reverting. > Move the tab-lifetime handling functionality out of ActiveTabPermissionGranter > and into a new class TabCapabilityTracker, to make room for web connectable > incognito support for apps. > > BUG=305394 > [email protected] > > Review URL: https://codereview.chromium.org/27604003 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229453

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -206 lines)			Patch
M	trunk/src/chrome/browser/extensions/active_tab_permission_granter.h	View	3 chunks	+22 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/active_tab_permission_granter.cc	View	2 chunks	+52 lines, -25 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/tab_capability_tracker.h	View	1 chunk	+0 lines, -83 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/tab_capability_tracker.cc	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

not at google - send to devlin

7 years, 2 months ago (2013-10-18 19:52:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r229453.