Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 3029038: Add back a test lost in r37819, because it had been at the bottom of an unrel... (Closed)

Created:
10 years, 4 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Add back a test lost in r37819, because it had been at the bottom of an unrelated file. BUG=none TEST=Test passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54204

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M chrome/test/interactive_ui/keyboard_access_uitest.cc View 1 3 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
10 years, 4 months ago (2010-07-28 23:20:40 UTC) #1
Paweł Hajdan Jr.
Drive-by with minor test comments. No need to wait for another review by me. http://codereview.chromium.org/3029038/diff/1/2 ...
10 years, 4 months ago (2010-07-28 23:29:07 UTC) #2
Peter Kasting
http://codereview.chromium.org/3029038/diff/1/2 File chrome/test/interactive_ui/keyboard_access_uitest.cc (right): http://codereview.chromium.org/3029038/diff/1/2#newcode113 chrome/test/interactive_ui/keyboard_access_uitest.cc:113: scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); On 2010/07/28 23:29:08, Paweł Hajdan Jr. wrote: ...
10 years, 4 months ago (2010-07-29 00:00:02 UTC) #3
Nico
10 years, 4 months ago (2010-07-29 21:34:56 UTC) #4
LG

sorry about the delay

Powered by Google App Engine
This is Rietveld 408576698