Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 315903004: Resubmit: Refactor external_install_ui (Closed)

Created:
6 years, 6 months ago by Devlin
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Resubmit: Refactor external_install_ui Third time's the charm. Previous: https://codereview.chromium.org/309643007/ --------------------------- Refactors ExternalInstallUI to have determinate lifetimes. This is likely the first of multiple patches targeting this area of code; the next one will concentrate on pulling the related logic out of ExtensionService. Adds unittests for accepting/declining external installs. BUG=378042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280067

Patch Set 1 : Original #

Patch Set 2 : Improvements #

Patch Set 3 : Resurrect #

Patch Set 4 : #

Patch Set 5 : Android fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+838 lines, -646 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 10 chunks +117 lines, -18 lines 0 comments Download
A chrome/browser/extensions/external_install_error.h View 1 2 1 chunk +121 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_error.cc View 1 2 3 4 1 chunk +400 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_manager.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_manager.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
D chrome/browser/extensions/external_install_ui.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/external_install_ui.cc View 1 2 1 chunk +0 lines, -591 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
Hey Yoyo, I'm hoping it's third time lucky for this one. Sorry it's taken so ...
6 years, 6 months ago (2014-06-18 23:48:26 UTC) #1
Yoyo Zhou
LGTM
6 years, 6 months ago (2014-06-19 16:59:47 UTC) #2
Devlin
The CQ bit was checked by [email protected]
6 years, 6 months ago (2014-06-24 16:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/315903004/60001
6 years, 6 months ago (2014-06-24 16:56:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-24 21:05:01 UTC) #5
Devlin
The CQ bit was unchecked by [email protected]
6 years, 6 months ago (2014-06-24 21:07:51 UTC) #6
Devlin
The CQ bit was checked by [email protected]
6 years, 6 months ago (2014-06-26 15:59:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/315903004/80001
6 years, 6 months ago (2014-06-26 16:00:54 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 19:04:01 UTC) #9
Message was sent while issue was closed.
Change committed as 280067

Powered by Google App Engine
This is Rietveld 408576698