Issue 321253003: Ensure show/hide are properly called on interstitial pages if present.

Issue 321253003: Ensure show/hide are properly called on interstitial pages if present. (Closed)

Created:
6 years, 6 months ago by nasko

Modified:
6 years, 6 months ago

Reviewers:
palmer, jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org, felt

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Ensure show/hide are properly called on interstitial pages if present. In my CL for sending Show/Hide to all frames on a page (https://codereview.chromium.org/298283003), I used the RWH for each RenderFrameHost in the tree. This missed the fact that an interstitial page will be overlayed and not part of the frame tree in WebContents. BUG=381439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276463

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -28 lines)			Patch
M	chrome/browser/ssl/ssl_browser_tests.cc	View	1	2 chunks	+26 lines, -0 lines	0 comments	Download
M	content/browser/site_per_process_browsertest.cc	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		4 chunks	+25 lines, -17 lines	0 comments	Download

Total messages: 6 (0 generated)

nasko

Hey guys, Can you review this CL for me? It should fix how visibility of ...

6 years, 6 months ago (2014-06-10 23:11:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/321253003/20001

6 years, 6 months ago (2014-06-11 16:14:24 UTC) #5

Message was sent while issue was closed.

Change committed as 276463