Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 3287002: Convert a bunch of uses of the wstring net::FormatUrl() to the new string16 one. (Closed)

Created:
10 years, 3 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Convert a bunch of uses of the wstring net::FormatUrl() to the new string16 one. BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57829

Patch Set 1 #

Patch Set 2 : fix whitespace error #

Patch Set 3 : added string16 convenience version of FormatUrl() #

Patch Set 4 : oops #

Patch Set 5 : style fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/add_startup_page_handler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/dom_ui/passwords_exceptions_handler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/passwords_exceptions_handler.cc View 1 2 3 4 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/download/download_item.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/passwords_page_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/url_picker_dialog_gtk.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M net/base/net_util.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
10 years, 3 months ago (2010-08-30 04:10:47 UTC) #1
brettw
10 years, 3 months ago (2010-08-30 04:44:51 UTC) #2
LGTM

On Sun, Aug 29, 2010 at 9:10 PM,  <[email protected]> wrote:
> Reviewers: brettw,
>
> Description:
> Convert a bunch of uses of the wstring net::FormatUrl() to the new string16
> one.
>
> BUG=23581
> TEST=builds and passes tests
>
> Please review this at http://codereview.chromium.org/3287002/show
>
> Affected files:
>  M chrome/browser/custom_home_pages_table_model.cc
>  M chrome/browser/dom_ui/add_startup_page_handler.cc
>  M chrome/browser/dom_ui/passwords_exceptions_handler.h
>  M chrome/browser/dom_ui/passwords_exceptions_handler.cc
>  M chrome/browser/download/download_item.cc
>  M chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc
>  M chrome/browser/gtk/options/passwords_page_gtk.cc
>  M chrome/browser/gtk/options/url_picker_dialog_gtk.cc
>  M net/base/net_util.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698