Clean up RenderViewHostDelegate::AutoFill interface

Clean up RenderViewHostDelegate::AutoFill interface -- remove |value| and |label| parameters from FillAutoFillFormData()

BUG=none
TEST=it compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59438

[James Hawkins, 2010-09-07 16:55:51]

I'm reviewing this now, but please wait for my LGTM (in addition to dhollowa's).

[James Hawkins, 2010-09-07 18:15:02]

http://codereview.chromium.org/3319006/diff/4001/5001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3319006/diff/4001/5001#newcode199
chrome/browser/autofill/autofill_manager.cc:199: // TODO(isherman): Why do we
only break out of the inner loop?
Instead of adding more TODO comments, please fix the issue (but not in this CL,
as it's already too large).  The fix is a one-liner.

http://codereview.chromium.org/3319006/diff/4001/5001#newcode216
chrome/browser/autofill/autofill_manager.cc:216: // TODO(isherman): This comment
doesn't seem to me like it matches the code.
It matches the code. |handle_billing| means treat billing fields as billing
fields and not regular address fields. Please remove this TODO comment.

http://codereview.chromium.org/3319006/diff/4001/5001#newcode328
chrome/browser/autofill/autofill_manager.cc:328: // TODO(isherman): What if two
form fields are swapped?  I guess that doesn't
We can't handle all cases with heuristics. If you have a form in the wild where
this doesn't work, write a test case and fix the bug.  Please remove this TODO
comment.

http://codereview.chromium.org/3319006/diff/4001/5004
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/3319006/diff/4001/5004#newcode336
chrome/browser/autofill/form_structure.cc:336: // TODO(isherman): What about
FormsSeen()?
That's not what the comment was implying. FormSubmitted() receives a FormData,
and that is the only place we check for |user_submitted|. Feel free to change
this to false by default.

http://codereview.chromium.org/3319006/diff/4001/5013
File chrome/renderer/render_view.h (left):

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode405
chrome/renderer/render_view.h:405: virtual void queryAutofillSuggestions(const
WebKit::WebNode& node,
Have you even compiled this? These functions are an implementation of an
interface implemented in WebKit.  You can't change these without changing WebKit
first.

[dhollowa, 2010-09-07 18:16:54]

http://codereview.chromium.org/3319006/diff/4001/5013
File chrome/renderer/render_view.h (left):

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode405
chrome/renderer/render_view.h:405: virtual void queryAutofillSuggestions(const
WebKit::WebNode& node,
This interface is defined in WebViewClient.h.  If you change the method
signature I don't believe it will ever get called.  You'd need a WebKit change
to make this work - both in the definition (WebViewClient.h) and the call site
(EditorClientImpl.cpp).

That said, it looks like that entire code path is deprecated in favor of
AutoFillHelper::InputElementClicked and RenderView's new PageClickTracker
interface.

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode415
chrome/renderer/render_view.h:415: virtual void
didSelectAutoFillSuggestion(const WebKit::WebNode& node,
Similar issue with this...  changing method signature will hide it from
interface defined in WebViewClient.h.  Thus it will not be called.

[Ilya Sherman, 2010-09-07 22:32:39]

Sorry, didn't mean to step on any toes with this CL.  I often upload patches
with TODOs that are requests for feedback from reviewers, not with the intention
of checking them into the codebase.

Cleaner patch up; splitting off noted tangents to other CLs.

http://codereview.chromium.org/3319006/diff/4001/5004
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/3319006/diff/4001/5004#newcode336
chrome/browser/autofill/form_structure.cc:336: // TODO(isherman): What about
FormsSeen()?
On 2010/09/07 18:15:02, James Hawkins wrote:
> That's not what the comment was implying. FormSubmitted() receives a FormData,
> and that is the only place we check for |user_submitted|. Feel free to change
> this to false by default.

Actually, looks like ConvertToFormData() is only used in one place to get the
form's origin.  It might make more sense to just get rid of this method entirely
and add a direct accessor for the origin -- something I am already doing in the
current cl for http://codereview.chromium.org/3226001 .  If that change sounds
reasonable, I'll go ahead and upload a separate CL for it.

http://codereview.chromium.org/3319006/diff/4001/5013
File chrome/renderer/render_view.h (left):

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode405
chrome/renderer/render_view.h:405: virtual void queryAutofillSuggestions(const
WebKit::WebNode& node,
On 2010/09/07 18:15:02, James Hawkins wrote:
> Have you even compiled this? These functions are an implementation of an
> interface implemented in WebKit.  You can't change these without changing
WebKit
> first.

My bad, I didn't notice that this was inheriting from an interface.  It did
compile -- it even went green on all the trybots...

[James Hawkins, 2010-09-07 22:36:47]

http://codereview.chromium.org/3319006/diff/4001/5004
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/3319006/diff/4001/5004#newcode336
chrome/browser/autofill/form_structure.cc:336: // TODO(isherman): What about
FormsSeen()?
On 2010/09/07 22:32:40, Ilya Sherman wrote:
> On 2010/09/07 18:15:02, James Hawkins wrote:
> > That's not what the comment was implying. FormSubmitted() receives a
FormData,
> > and that is the only place we check for |user_submitted|. Feel free to
change
> > this to false by default.
> 
> Actually, looks like ConvertToFormData() is only used in one place to get the
> form's origin.  It might make more sense to just get rid of this method
entirely
> and add a direct accessor for the origin -- something I am already doing in
the
> current cl for http://codereview.chromium.org/3226001 .  If that change sounds
> reasonable, I'll go ahead and upload a separate CL for it.

Yes, that's fine.

http://codereview.chromium.org/3319006/diff/4001/5013
File chrome/renderer/render_view.h (left):

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode405
chrome/renderer/render_view.h:405: virtual void queryAutofillSuggestions(const
WebKit::WebNode& node,
On 2010/09/07 22:32:40, Ilya Sherman wrote:
> On 2010/09/07 18:15:02, James Hawkins wrote:
> > Have you even compiled this? These functions are an implementation of an
> > interface implemented in WebKit.  You can't change these without changing
> WebKit
> > first.
> 
> My bad, I didn't notice that this was inheriting from an interface.  It did
> compile -- it even went green on all the trybots...

Yea, I forgot that the WebKit API provides default implementations.  End-to-end
tests would have caught this, but we don't have any for AF yet.

[Ilya Sherman, 2010-09-10 00:12:50]

Any other changes that I should make, or does this look all right?

[James Hawkins, 2010-09-10 20:46:29]

On 2010/09/10 00:12:50, Ilya Sherman wrote:
> Any other changes that I should make, or does this look all right?

You haven't replied to my previous comments so I don't know what's changed.

[Ilya Sherman, 2010-09-10 22:00:09]

Hadn't been aware of the done button...

http://codereview.chromium.org/3319006/diff/4001/5001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3319006/diff/4001/5001#newcode199
chrome/browser/autofill/autofill_manager.cc:199: // TODO(isherman): Why do we
only break out of the inner loop?
On 2010/09/07 18:15:02, James Hawkins wrote:
> Instead of adding more TODO comments, please fix the issue (but not in this
CL,
> as it's already too large).  The fix is a one-liner.

Done.

http://codereview.chromium.org/3319006/diff/4001/5001#newcode216
chrome/browser/autofill/autofill_manager.cc:216: // TODO(isherman): This comment
doesn't seem to me like it matches the code.
On 2010/09/07 18:15:02, James Hawkins wrote:
> It matches the code. |handle_billing| means treat billing fields as billing
> fields and not regular address fields. Please remove this TODO comment.

Done.

http://codereview.chromium.org/3319006/diff/4001/5001#newcode328
chrome/browser/autofill/autofill_manager.cc:328: // TODO(isherman): What if two
form fields are swapped?  I guess that doesn't
On 2010/09/07 18:15:02, James Hawkins wrote:
> We can't handle all cases with heuristics. If you have a form in the wild
where
> this doesn't work, write a test case and fix the bug.  Please remove this TODO
> comment.

Done.

http://codereview.chromium.org/3319006/diff/4001/5004
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/3319006/diff/4001/5004#newcode336
chrome/browser/autofill/form_structure.cc:336: // TODO(isherman): What about
FormsSeen()?
On 2010/09/07 22:36:47, James Hawkins wrote:
> On 2010/09/07 22:32:40, Ilya Sherman wrote:
> > On 2010/09/07 18:15:02, James Hawkins wrote:
> > > That's not what the comment was implying. FormSubmitted() receives a
> FormData,
> > > and that is the only place we check for |user_submitted|. Feel free to
> change
> > > this to false by default.
> > 
> > Actually, looks like ConvertToFormData() is only used in one place to get
the
> > form's origin.  It might make more sense to just get rid of this method
> entirely
> > and add a direct accessor for the origin -- something I am already doing in
> the
> > current cl for http://codereview.chromium.org/3226001 .  If that change
sounds
> > reasonable, I'll go ahead and upload a separate CL for it.
> 
> Yes, that's fine.

Done.

http://codereview.chromium.org/3319006/diff/4001/5013
File chrome/renderer/render_view.h (left):

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode405
chrome/renderer/render_view.h:405: virtual void queryAutofillSuggestions(const
WebKit::WebNode& node,
On 2010/09/07 18:15:02, James Hawkins wrote:
> Have you even compiled this? These functions are an implementation of an
> interface implemented in WebKit.  You can't change these without changing
WebKit
> first.

Done.  (Change reverted)

http://codereview.chromium.org/3319006/diff/4001/5013#oldcode415
chrome/renderer/render_view.h:415: virtual void
didSelectAutoFillSuggestion(const WebKit::WebNode& node,
On 2010/09/07 18:16:54, dhollowa wrote:
> Similar issue with this...  changing method signature will hide it from
> interface defined in WebViewClient.h.  Thus it will not be called.

Done.  (Change reverted)

[James Hawkins, 2010-09-13 18:41:26]

http://codereview.chromium.org/3319006/diff/13001/9002
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3319006/diff/13001/9002#newcode259
chrome/browser/autofill/autofill_manager.cc:259: const string16& label,
Please remove |label| as well.

[Ilya Sherman, 2010-09-13 20:26:12]

http://codereview.chromium.org/3319006/diff/13001/9002
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3319006/diff/13001/9002#newcode259
chrome/browser/autofill/autofill_manager.cc:259: const string16& label,
On 2010/09/13 18:41:26, James Hawkins wrote:
> Please remove |label| as well.

Done.

[James Hawkins, 2010-09-13 20:35:37]

http://codereview.chromium.org/3319006/diff/13002/2012
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/3319006/diff/13002/2012#newcode2227
chrome/renderer/render_view.cc:2227:
autofill_helper_->DidAcceptAutoFillSuggestion(node, label, unique_id, index);
whoops, you passed in |label| instead of |value|.

[Ilya Sherman, 2010-09-13 20:53:35]

http://codereview.chromium.org/3319006/diff/13002/2012
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/3319006/diff/13002/2012#newcode2227
chrome/renderer/render_view.cc:2227:
autofill_helper_->DidAcceptAutoFillSuggestion(node, label, unique_id, index);
On 2010/09/13 20:35:38, James Hawkins wrote:
> whoops, you passed in |label| instead of |value|.

Doh.  Fixed.  Thanks for catching that =)

[James Hawkins, 2010-09-13 20:55:18]

LGTM