Issue 345453003: QUIC - Minor change to keep the code similar to internal source tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345453003: QUIC - Minor change to keep the code similar to internal source tree. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
wtc, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

QUIC - Minor change to keep the code similar to internal source tree. + Minor fixes to using order, comments and chromium indentation nits. + Use EXPECT_EQ instead of EXPECT_TRUE. Merge internal change: 69401047 [email protected],[email protected], Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278319

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -10 lines)			Patch
M	net/quic/congestion_control/send_algorithm_simulator.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	net/quic/crypto/crypto_server_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_protocol.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/test_tools/packet_dropping_test_writer.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

ramant (doing other things)

The CQ bit was checked by [email protected]

6 years, 6 months ago (2014-06-18 18:47:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/345453003/1

6 years, 6 months ago (2014-06-18 18:49:13 UTC) #4

Message was sent while issue was closed.

lgtm