Adds a flag to enable the OK Google voice search activation setting.

Adds a flag to enable the OK Google voice search activation setting.

BUG=390086
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280757

[Matt Giuca, 2014-06-30 06:49:22]

lgtm, but: please file a bug if you don't already have one, and add it to the
BUG= line.

https://codereview.chromium.org/348943003/diff/1/chrome/app/chromeos_strings....
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/348943003/diff/1/chrome/app/chromeos_strings....
chrome/app/chromeos_strings.grdp:5537: If enabled, there will be an option in
chrome:settings to enable saying 'ok google' to activate voice search.
nit: casing: 'Ok Google'.

(I have looked at some of our official docs and it seems that the consistently
used capitalization is 'Ok Google', with no commas and no capital 'K'.)

[kcarattini, 2014-06-30 07:05:38]

Added bug 390086.

https://codereview.chromium.org/348943003/diff/1/chrome/app/chromeos_strings....
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/348943003/diff/1/chrome/app/chromeos_strings....
chrome/app/chromeos_strings.grdp:5537: If enabled, there will be an option in
chrome:settings to enable saying 'ok google' to activate voice search.
On 2014/06/30 06:49:22, Matt Giuca wrote:
> nit: casing: 'Ok Google'.
> 
> (I have looked at some of our official docs and it seems that the consistently
> used capitalization is 'Ok Google', with no commas and no capital 'K'.)

Done.

[kcarattini, 2014-06-30 07:16:49]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-06-30 07:17:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/348943003/20001

[commit-bot: I haz the power, 2014-06-30 09:00:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-30 10:13:04]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-06-30 10:13:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[kcarattini, 2014-07-01 05:28:56]

On 2014/06/30 10:13:04, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

Adding NOTRY because an unrelated test is failing: chromevox_tests

[kcarattini, 2014-07-01 05:29:27]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-07-01 05:29:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/348943003/20001

[commit-bot: I haz the power, 2014-07-01 06:53:44]

Change committed as 280757