Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 350453004: Clamp down various chrome/ DEPS files. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, stuartmorgan+watch_chromium.org, native-client-reviews_googlegroups.com, jam
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -37 lines) Patch
M chrome/DEPS View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/app/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/DEPS View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/component_updater/test/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/mac/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/plugin/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_main.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/tools/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/tools/service_discovery_sniffer/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/utility/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
6 years, 6 months ago (2014-06-23 20:30:25 UTC) #1
James Hawkins
Why are the added lines necessary?
6 years, 6 months ago (2014-06-23 23:17:30 UTC) #2
Lei Zhang
On 2014/06/23 23:17:30, James Hawkins wrote: > Why are the added lines necessary? I pushed ...
6 years, 6 months ago (2014-06-23 23:21:40 UTC) #3
James Hawkins
lgtm
6 years, 6 months ago (2014-06-23 23:24:38 UTC) #4
Lei Zhang
The CQ bit was checked by [email protected]
6 years, 6 months ago (2014-06-23 23:47:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/350453004/1
6 years, 6 months ago (2014-06-23 23:49:01 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-24 01:29:30 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 6 months ago (2014-06-24 01:34:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75847)
6 years, 6 months ago (2014-06-24 01:34:10 UTC) #9
Lei Zhang
TBRing OWNERS since there's no actual new dependency. They are just being tightened. isherman: components/metrics ...
6 years, 6 months ago (2014-06-24 01:38:49 UTC) #10
Lei Zhang
The CQ bit was checked by [email protected]
6 years, 6 months ago (2014-06-24 01:38:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/350453004/1
6 years, 6 months ago (2014-06-24 01:40:13 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 01:44:37 UTC) #13
Message was sent while issue was closed. 
Change committed as 279265

Powered by Google App Engine
This is Rietveld 408576698