Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 355453003: gpu/gles2_conform_support: On Chrome OS, don't use system.gyp to pull in GTK+ (Closed)

Created:
6 years, 5 months ago by joshtriplett
Modified:
6 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu/gles2_conform_support: On Chrome OS, don't use system.gyp to pull in GTK+ Normally, gles2_conform_support uses system.gyp:gtk to pull in a system copy of GTK+; however, Chrome OS already installs GTK+, and system.gyp intentionally does not provide a gtk target on Chrome OS. Make the dependencies on system.gyp:gtk conditional on 'chromeos==0'. BUG=chromium:388784 TEST=Manually build gles2_conform_test on Chrome OS [email protected], [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test.gyp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
joshtriplett
This change, along with https://codereview.chromium.org/349923010 , fixes the ability to build the GLES2 conformance test ...
6 years, 5 months ago (2014-06-25 18:36:25 UTC) #1
piman
lgtm
6 years, 5 months ago (2014-06-25 20:46:15 UTC) #2
joshtriplett
On 2014/06/25 20:46:15, piman (slow to review) wrote: > lgtm Thanks; I don't have commit ...
6 years, 5 months ago (2014-06-26 19:05:27 UTC) #3
piman
The CQ bit was checked by [email protected]
6 years, 5 months ago (2014-06-26 19:46:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/355453003/1
6 years, 5 months ago (2014-06-26 19:48:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-26 23:48:16 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 03:24:37 UTC) #7
Message was sent while issue was closed.
Change committed as 280227

Powered by Google App Engine
This is Rietveld 408576698