Store unsaved trace data on exit.

Store unsaved trace data on exit.

This CL enables chromeos chrome startup trace when chrome in restarted on
user log in: startup trace should be saved to disk on process exit if
"trace-startup-duration" period has not ended yet.

BUG=346913
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281061

[Alexander Alekseev, 2014-06-26 01:39:25]

(This is a split of previous CL https://codereview.chromium.org/311313005/)

Chrome on ChromeOS is sometimes restarted (on user log on, for example) and
startup trace is lost. 

This is the second part of the "enables tracing of chrome on ChromeOS restart".

[Alexander Alekseev, 2014-06-26 01:39:42]

On 2014/06/26 01:39:25, alemate wrote:
> (This is a split of previous CL https://codereview.chromium.org/311313005/)
> 
> Chrome on ChromeOS is sometimes restarted (on user log on, for example) and
> startup trace is lost. 
> 
> This is the second part of the "enables tracing of chrome on ChromeOS
restart".

Please review ;-)

[sky, 2014-06-26 16:39:27]

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_main...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_main...
content/browser/browser_main_runner.cc:133: // If startup tracing has not been
finished yet, replace it's dumper.
It's not clear to me why this is done. Update comment so it is clear.

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_main...
content/browser/browser_main_runner.cc:178: static base::FilePath
GetShutdownProfileFileName() {
Move this to a common place so it isn't duplicated.

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_shut...
File content/browser/browser_shutdown_profile_dumper.h (right):

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_shut...
content/browser/browser_shutdown_profile_dumper.h:63: base::FilePath
dump_file_name_;
const.

[Alexander Alekseev, 2014-06-27 20:09:50]

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_main...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_main...
content/browser/browser_main_runner.cc:133: // If startup tracing has not been
finished yet, replace it's dumper.
On 2014/06/26 16:39:27, sky wrote:
> It's not clear to me why this is done. Update comment so it is clear.

Done.

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_main...
content/browser/browser_main_runner.cc:178: static base::FilePath
GetShutdownProfileFileName() {
On 2014/06/26 16:39:27, sky wrote:
> Move this to a common place so it isn't duplicated.

It's now a static method of BrowserShutdownProfileDumper .

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_shut...
File content/browser/browser_shutdown_profile_dumper.h (right):

https://codereview.chromium.org/359473006/diff/1/content/browser/browser_shut...
content/browser/browser_shutdown_profile_dumper.h:63: base::FilePath
dump_file_name_;
On 2014/06/26 16:39:27, sky wrote:
> const.

Done.

[sky, 2014-06-27 22:27:25]

I'm going to be OOO shortly, you'll likely want another reviewer.

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
content/browser/browser_main_loop.cc:1112: const base::CommandLine&
command_line) const {
How come this and GetShutdownProfileFileName can't be the same?

[Alexander Alekseev, 2014-06-30 16:19:40]

On 2014/06/27 22:27:25, sky (OOO) wrote:
> I'm going to be OOO shortly, you'll likely want another reviewer.

+jochen

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
content/browser/browser_main_loop.cc:1112: const base::CommandLine&
command_line) const {
On 2014/06/27 22:27:25, sky (OOO) wrote:
> How come this and GetShutdownProfileFileName can't be the same?

They are different in semantics.

Startup trace file can have special value "none".
Empty startup trace file value is handled differently on Android and other
systems.

Shutdown trace file has no special values and defaults to "chrometrace.log" on
all systems.

I can drop both GetStartupTraceFileName / GetShutdownProfileFileName and move
it's code to callers. But it seems that having two different functions is more
readable.

[jochen (gone - plz use gerrit), 2014-07-02 13:31:34]

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
content/browser/browser_main_runner.cc:138: startup_profiler.reset(
why if the trace file name is none here?

[Alexander Alekseev, 2014-07-02 13:36:16]

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/359473006/diff/20001/content/browser/browser_...
content/browser/browser_main_runner.cc:138: startup_profiler.reset(
On 2014/07/02 13:31:34, jochen wrote:
> why if the trace file name is none here?

Done.

[jochen (gone - plz use gerrit), 2014-07-02 13:42:46]

lgtm

[Alexander Alekseev, 2014-07-02 13:47:52]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-07-02 13:48:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/359473006/40001

[commit-bot: I haz the power, 2014-07-02 14:30:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/24105)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28503)

[commit-bot: I haz the power, 2014-07-02 14:33:01]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-07-02 14:33:03]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[Alexander Alekseev, 2014-07-02 15:00:45]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-07-02 15:01:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/359473006/60001

[commit-bot: I haz the power, 2014-07-02 18:01:55]

Change committed as 281061