Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 3717004: Rename ChromeThread to BrowserThread Part22: (Closed)

Created:
10 years, 2 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, ben+cc_chromium.org, jam, cbentzel+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, James Hawkins, amit, tim (not reviewing), dhollowa
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Rename ChromeThread to BrowserThread Part22: - Include browser_thread instead of chrome_thread in more 97 files. Now the remaining files that are including chrome_thread.h are: chrome_thread.cc and browser_thread.h. They will be fixed next. BUG=56926 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62312

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -99 lines) Patch
M chrome/browser/spellcheck_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/app_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/database_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/database_model_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sync_session_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_setup_wizard.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/transport_security_persister.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui_thread_helpers_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui_thread_helpers_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui_thread_helpers_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_style_sheet_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_style_sheet_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/utility_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_context_menu_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_editor_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/html_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/select_file_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/shell_dialogs_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/ssl_client_certificate_selector_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_drag_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/visitedlink_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/visitedlink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/browser_with_test_window_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/thread_observer_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/thread_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
willchan no longer on Chromium
LGTM Wow, 22 patches now. Thanks a lot for doing this :)
10 years, 2 months ago (2010-10-12 17:52:32 UTC) #1
willchan no longer on Chromium
codereview.chromium.org is sucking, I got your emails already :P LGTM. Thanks for doing this. 22 ...
10 years, 2 months ago (2010-10-12 17:54:06 UTC) #2
tfarina
10 years, 2 months ago (2010-10-12 18:00:33 UTC) #3
On 2010/10/12 17:54:06, willchan wrote:
> http://codereview.chromium.org is sucking, I got your emails already :P
> 
Sorry for the 7 emails, I got a bunch of 500 errors when pushing the "Publish"
button. :(

Powered by Google App Engine
This is Rietveld 408576698