Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 387773003: Add GN build file for components/storage_monitor (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
Reviewers:
brettw, awong, Greg Billock
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add GN build file for components/storage_monitor A line-by-line conversion of the existing GYP configs. R=ajwong TBR=gbillock Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283007

Patch Set 1 #

Patch Set 2 : Fix inclusion at components level #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
M components/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M components/storage_monitor.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A components/storage_monitor/BUILD.gn View 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
rlarocque
6 years, 5 months ago (2014-07-11 00:34:55 UTC) #1
awong
LGTM
6 years, 5 months ago (2014-07-11 00:37:17 UTC) #2
rlarocque
The CQ bit was checked by [email protected]
6 years, 5 months ago (2014-07-11 16:39:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/387773003/20001
6 years, 5 months ago (2014-07-11 16:39:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 16:43:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 5 months ago (2014-07-11 16:46:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/27696) linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/38371) mac_gpu ...
6 years, 5 months ago (2014-07-11 16:46:40 UTC) #7
rlarocque
I just noticed that this CL still doesn't have OWNERs approval. +brettw for .gn files. ...
6 years, 5 months ago (2014-07-14 17:52:35 UTC) #8
brettw
lgtm
6 years, 5 months ago (2014-07-14 19:39:51 UTC) #9
rlarocque
TBR'ing gbillock because the .gypi changes are trivial.
6 years, 5 months ago (2014-07-14 19:49:19 UTC) #10
rlarocque
The CQ bit was checked by [email protected]
6 years, 5 months ago (2014-07-14 19:49:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/387773003/40001
6 years, 5 months ago (2014-07-14 19:51:09 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 20:24:19 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 20:30:06 UTC) #14
Message was sent while issue was closed.
Change committed as 283007

Powered by Google App Engine
This is Rietveld 408576698