Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 3945002: Move debug-related stuff from base to the base/debug directory and use the... (Closed)

Created:
10 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, amit, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Move debug-related stuff from base to the base/debug directory and use the base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -2849 lines) Patch
M app/resource_bundle_win.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M base/base.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M base/base.gypi View 4 chunks +14 lines, -8 lines 0 comments Download
A + base/debug/debugger.h View 1 chunk +26 lines, -83 lines 0 comments Download
A + base/debug/debugger.cc View 2 chunks +7 lines, -10 lines 0 comments Download
A + base/debug/debugger_posix.cc View 6 chunks +13 lines, -162 lines 0 comments Download
A + base/debug/debugger_win.cc View 3 chunks +12 lines, -184 lines 0 comments Download
A + base/debug/leak_annotations.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/debug/leak_tracker.h View 4 chunks +7 lines, -5 lines 0 comments Download
A + base/debug/leak_tracker_unittest.cc View 2 chunks +32 lines, -26 lines 0 comments Download
A + base/debug/stack_trace.h View 2 chunks +22 lines, -55 lines 0 comments Download
A + base/debug/stack_trace.cc View 2 chunks +8 lines, -15 lines 0 comments Download
A + base/debug/stack_trace_posix.cc View 4 chunks +8 lines, -123 lines 0 comments Download
A + base/debug/stack_trace_unittest.cc View 2 chunks +9 lines, -3 lines 0 comments Download
A + base/debug/stack_trace_win.cc View 4 chunks +8 lines, -95 lines 0 comments Download
A + base/debug/trace_event.h View 5 chunks +10 lines, -8 lines 0 comments Download
A + base/debug/trace_event.cc View 3 chunks +4 lines, -2 lines 0 comments Download
A + base/debug/trace_event_win.h View 4 chunks +6 lines, -4 lines 0 comments Download
A + base/debug/trace_event_win.cc View 6 chunks +16 lines, -13 lines 0 comments Download
A + base/debug/trace_event_win_unittest.cc View 8 chunks +42 lines, -35 lines 0 comments Download
M base/debug_on_start.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/debug_util.h View 2 chunks +5 lines, -65 lines 0 comments Download
M base/debug_util.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M base/debug_util_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
D base/debug_util_posix.cc View 1 chunk +0 lines, -314 lines 0 comments Download
D base/debug_util_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D base/debug_util_win.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D base/leak_annotations.h View 1 chunk +0 lines, -28 lines 0 comments Download
D base/leak_tracker.h View 1 chunk +0 lines, -132 lines 0 comments Download
D base/leak_tracker_unittest.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M base/logging.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M base/process_util_mac.mm View 18 chunks +18 lines, -18 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util_win.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M base/test/perf_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +3 lines, -1 line 0 comments Download
D base/trace_event.h View 1 chunk +0 lines, -142 lines 0 comments Download
D base/trace_event.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D base/trace_event_win.h View 1 chunk +0 lines, -146 lines 0 comments Download
D base/trace_event_win.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D base/trace_event_win_unittest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_main_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/logging_chrome.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/sandbox_policy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_thread.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_main_platform_delegate_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/service/service_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
10 years, 2 months ago (2010-10-20 04:06:04 UTC) #1
cpu_(ooo_6.6-7.5)
10 years, 2 months ago (2010-10-25 17:56:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698