Use the shader translator to correct bad type information...

Use the shader translator to correct bad type information
returned by OpenGL drivers.

TEST=unit tests, ran OpenGL ES 2.0 conformance tests and ran WebGL conformance test. Things that used to fail now pass.
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65882

[alokp, 2010-11-11 23:02:57]

lgtm

http://codereview.chromium.org/4829001/diff/1/gpu/command_buffer/service/shad...
File gpu/command_buffer/service/shader_translator.h (right):

http://codereview.chromium.org/4829001/diff/1/gpu/command_buffer/service/shad...
gpu/command_buffer/service/shader_translator.h:63: ~ShaderTranslator();
It is harmless, but please add virtual in all the functions.

http://codereview.chromium.org/4829001/diff/15001/gpu/command_buffer/service/...
File gpu/command_buffer/service/program_manager.cc (right):

http://codereview.chromium.org/4829001/diff/15001/gpu/command_buffer/service/...
gpu/command_buffer/service/program_manager.cc:258: void
ProgramManager::ProgramInfo::GetCorrectedUniformInfo(
This function looks exactly the same as above except for one function call.
Could merge them into one and use a function parameter to indicate which
variable you need to get - attrib or uniform?

http://codereview.chromium.org/4829001/diff/15001/gpu/command_buffer/service/...
File gpu/command_buffer/service/shader_manager.cc (right):

http://codereview.chromium.org/4829001/diff/15001/gpu/command_buffer/service/...
gpu/command_buffer/service/shader_manager.cc:16: attrib_map_ =
translator->attrib_map();
If you are copying the whole map here, there is no reason to build the map in
the shader translator. The shader translator can just provide functions to
enumerate all attribs and uniforms. The map could be built and stored her.

I can make this change after you have submitted this CL.