Chrome Frame: Add explicit object security attributes to the Chrome Frame ver...

Chrome Frame: Add explicit object security attributes to the Chrome Frame version beacon. This will allow low integrity processes to access shared memory segment and lock and make shared memory segment read only after creation.

Also use lock names that include the hosting process.

BUG=61609
TEST=Start medium integrity Chrome Frame host running CF version X. Update CF to version Y > X. Start low integrity Chrome Frame host, observe that version X is loaded. 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66270

[tommi (sloooow) - chröme, 2010-11-15 19:33:30]

lgtm

http://codereview.chromium.org/5012001/diff/4002/base/shared_memory_win.cc
File base/shared_memory_win.cc (right):

http://codereview.chromium.org/5012001/diff/4002/base/shared_memory_win.cc#ne...
base/shared_memory_win.cc:209: LOG(ERROR) << "Could not create mutex" <<
GetLastError();
change this to PLOG (and remove the call to GLE)?

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc
File chrome_frame/module_utils.cc (right):

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:49: bool
DllRedirector::GetLockSecurityAttributes(CSecurityAttributes* sec_attr) {
change name to "BuildSecurityAttributesForLock" or something along those lines.

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:66: if
(security_desc.FromString(L"S:(ML;;NW;;;LW)")) {
Add a comment that explains what the string means

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:71: NOTREACHED() << "Could not set owner.";
set -> get

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:77: NOTREACHED() << "Could not set group.";
set -> get

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:225: "from first loaded module, GLE: ";
remove ", GLE: "

[robertshield, 2010-11-15 20:32:18]

Done, also removed the low-integrity section of the access check tests on
pre-Vista.

http://codereview.chromium.org/5012001/diff/4002/base/shared_memory_win.cc
File base/shared_memory_win.cc (right):

http://codereview.chromium.org/5012001/diff/4002/base/shared_memory_win.cc#ne...
base/shared_memory_win.cc:209: LOG(ERROR) << "Could not create mutex" <<
GetLastError();
On 2010/11/15 19:33:30, tommi wrote:
> change this to PLOG (and remove the call to GLE)?

Done.

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc
File chrome_frame/module_utils.cc (right):

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:49: bool
DllRedirector::GetLockSecurityAttributes(CSecurityAttributes* sec_attr) {
On 2010/11/15 19:33:30, tommi wrote:
> change name to "BuildSecurityAttributesForLock" or something along those
lines.

Done.

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:66: if
(security_desc.FromString(L"S:(ML;;NW;;;LW)")) {
On 2010/11/15 19:33:30, tommi wrote:
> Add a comment that explains what the string means

Done.

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:71: NOTREACHED() << "Could not set owner.";
On 2010/11/15 19:33:30, tommi wrote:
> set -> get

Done.

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:77: NOTREACHED() << "Could not set group.";
On 2010/11/15 19:33:30, tommi wrote:
> set -> get

Done.

http://codereview.chromium.org/5012001/diff/4002/chrome_frame/module_utils.cc...
chrome_frame/module_utils.cc:225: "from first loaded module, GLE: ";
On 2010/11/15 19:33:30, tommi wrote:
> remove ", GLE: "

Done.

[tommi (sloooow) - chröme, 2010-11-15 20:41:21]

lgtm