Split history tests into parts that run in under 6 seconds.

Split history tests into parts that run in under 6 seconds.

I don't see how the failures listed in the bug can happen.  Because the logs are old, reenabling the tests to see if the failures re-occur.

BUG=26296
TEST=ExtensionHistoryApiTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73293

[asargent_no_longer_on_chrome, 2011-02-01 06:10:38]

lgtm w/ 1 nit. 

Also, I only quickly skimmed the Added/Deleted extension html/js files, assuming
a straight port of the code without significant changes - let me know if there
was anything I should look closer at.

http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_history_apitest.cc (right):

http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_history_apitest.cc:12: virtual bool
SetupTestEnv() WARN_UNUSED_RESULT {
nit: Instead of having subclasses call SetupTestEnv explicitly in each test, can
you instead override InProcessBrowserTest::SetUpInProcessBrowserTestFixture in
this class and do this work there?

[Sam Kerner (Chrome), 2011-02-01 16:23:26]

On 2011/02/01 06:10:38, Antony Sargent wrote:
> lgtm w/ 1 nit. 
> 
> Also, I only quickly skimmed the Added/Deleted extension html/js files,
assuming
> a straight port of the code without significant changes - let me know if there
> was anything I should look closer at.

The code is unchanged, except for splitting across files and fixing indentation.

> 
>
http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
> File chrome/browser/extensions/extension_history_apitest.cc (right):
> 
>
http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
> chrome/browser/extensions/extension_history_apitest.cc:12: virtual bool
> SetupTestEnv() WARN_UNUSED_RESULT {
> nit: Instead of having subclasses call SetupTestEnv explicitly in each test,
can
> you instead override InProcessBrowserTest::SetUpInProcessBrowserTestFixture in
> this class and do this work there?

[Sam Kerner (Chrome), 2011-02-01 16:23:30]

http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_history_apitest.cc (right):

http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_history_apitest.cc:12: virtual bool
SetupTestEnv() WARN_UNUSED_RESULT {
On 2011/02/01 06:10:39, Antony Sargent wrote:
> nit: Instead of having subclasses call SetupTestEnv explicitly in each test,
can
> you instead override InProcessBrowserTest::SetUpInProcessBrowserTestFixture in
> this class and do this work there?

Done.

[j.r69rosales, 2011-09-12 03:31:34]

http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_history_apitest.cc (right):

http://codereview.chromium.org/6260050/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_history_apitest.cc:12: virtual bool
SetupTestEnv() WARN_UNUSED_RESULT {
On 2011/02/01 06:10:39, Antony Sargent wrote:
> nit: Instead of having subclasses call SetupTestEnv explicitly in each test,
can
> you instead override InProcessBrowserTest::SetUpInProcessBrowserTestFixture in
> this class and do this work there?

Done.