[Cocoa] Make TabContentsContainerView more testable for interactive_ui_tests.

[Cocoa] Make TabContentsContainerView more testable for interactive_ui_tests.

Note: This change is a prerequisite for an upcoming change that will add
extensive interactive UI testing around Flash fullscreen, including the
Fullscreen-Within-Tab UI.

For all interactive_ui_tests, the UI widget being referenced by
VIEW_ID_TAB_CONTAINER was wrong whenever Flash fullscreen mode was
engaged.  This change tags the correct NSView with the identifier, and
gives it some simple focus-passing behavior, similar to
ui::views::WebView, to ensure that tests checking focus and/or
simulating a click on the tab container get the desired behavior.

Because the code changes to TabContentsContainerView are pretty much the
same, this change also addresses bug 421728, which makes clicking in the
"gray area" during Fullscreen-Within-Tab mode a request to give the tab
contents the focus.

BUG=403641, 421728
Committed: https://crrev.com/5d0cfcacfa3b6e5d623bddea08d88898fe3e30f1
Cr-Commit-Position: refs/heads/master@{#300326}

[miu, 2014-10-18 02:25:06]

[email protected] changed reviewers:
+ [email protected], [email protected]

[miu, 2014-10-18 02:25:07]

avi: PTAL at everything.

sky: Need OWNER stamp for chrome/browser/ui/browser_focus_uitest.cc and
chrome/test/base/interactive_test_utils_mac.mm.

[Avi (use Gerrit), 2014-10-18 02:31:17]

This LGTM

[sky, 2014-10-20 16:28:52]

LGTM

[miu, 2014-10-20 17:12:51]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-10-20 17:13:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642143004/1

[commit-bot: I haz the power, 2014-10-20 17:50:53]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-10-20 17:50:55]

Failed to apply patch for
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm:76
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm'
with conflicts.
  U chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Patch:      
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
Index:
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
diff --git
a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
index
a1ea1e2a15ad2fd1b1454ad8374c7d02f94224ae..dec9a26017356853d04d4615ce0feb58dcc53eef
100644
---
a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
+++
b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
@@ -16,7 +16,6 @@
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
-#import "chrome/browser/ui/cocoa/view_id_util.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/spellcheck_messages.h"
 #include "chrome/common/url_constants.h"
@@ -76,8 +75,6 @@ class SpellCheckObserver : public content::WebContentsObserver
{
   self = [super init];
   if (self) {
     renderWidgetHost_ = renderWidgetHost;
-    NSView* nativeView = renderWidgetHost_->GetView()->GetNativeView();
-    view_id_util::SetID(nativeView, VIEW_ID_TAB_CONTAINER);
 
     if (renderWidgetHost_->IsRenderView()) {
       spellingObserver_.reset(
@@ -95,10 +92,6 @@ class SpellCheckObserver : public
content::WebContentsObserver {
   [super dealloc];
 }
 
-- (void)viewGone:(NSView*)view {
-  view_id_util::UnsetID(view);
-}
-
 // Handle an event. All incoming key and mouse events flow through this
 // delegate method if implemented. Return YES if the event is fully handled, or
 // NO if normal processing should take place.

[commit-bot: I haz the power, 2014-10-20 17:51:10]

The CQ bit was unchecked by [email protected]

[miu, 2014-10-20 19:11:24]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-10-20 19:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642143004/20001

[commit-bot: I haz the power, 2014-10-20 20:46:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 20:47:35]

Patchset 2 (id:??) landed as
https://crrev.com/5d0cfcacfa3b6e5d623bddea08d88898fe3e30f1
Cr-Commit-Position: refs/heads/master@{#300326}