Issue 668131: Implements index validation for DrawElements....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668131: Implements index validation for DrawElements.... (Closed)

Created:
10 years, 9 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implements index validation for DrawElements. (note: I also forgot to check in the changes to build_gles2_cmd_buffer.py from my last CL so that's in here as well) TEST=various unit tests BUG=26101 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40713

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+407 lines, -117 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2 3 4	8 chunks	+65 lines, -34 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.h	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.h	View	1 2 3 4	4 chunks	+73 lines, -6 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.cc	View	1 2 3 4 5	2 chunks	+91 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager_unittest.cc	View	1 2 3 4	2 chunks	+81 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3 4	6 chunks	+57 lines, -55 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 2 3 4	10 chunks	+35 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick

10 years, 9 months ago (2010-03-05 02:25:37 UTC) #2

lgtm

http://codereview.chromium.org/668131/diff/1006/23
File gpu/command_buffer/service/buffer_manager.cc (right):

http://codereview.chromium.org/668131/diff/1006/23#newcode69
gpu/command_buffer/service/buffer_manager.cc:69: reinterpret_cast<const
int8*>(data) + offset);
I think the second one can be a static cast.

http://codereview.chromium.org/668131/diff/1006/24
File gpu/command_buffer/service/buffer_manager.h (right):

http://codereview.chromium.org/668131/diff/1006/24#newcode61
gpu/command_buffer/service/buffer_manager.h:61: // the given type. Turns false
if offset and count our out of range.
our -> are

http://codereview.chromium.org/668131/diff/1006/24#newcode85
gpu/command_buffer/service/buffer_manager.h:85: bool operator<(const Range& rhs)
const {
I think we aren't allowed to use operator overloading. You could do it with a
function object and pass it as a template argument to std::map.

Expand Messages | Collapse Messages