ChromeFrame now uses host provided popup blocker....

ChromeFrame now uses host provided popup blocker.
It does not work in all scenarions since from Chrome side an empty string is passed as target url.
Note in IE6 "Tools/Popup Blocker" menu is not visible if ChromeFrame is the activedocument. Have to support some IOleCommandTarget command..

BUG=34823
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40897

[amit, 2010-03-05 19:45:21]

LGTM

Just curious about the cookie change from intptr_t to uint64, is this for future
or did something break?

http://codereview.chromium.org/668168/diff/23/27
File chrome_frame/chrome_active_document.cc (right):

http://codereview.chromium.org/668168/diff/23/27#newcode714
chrome_frame/chrome_active_document.cc:714: HRESULT hr =
popup_manager_->EvaluateNewWindow(
if (popup_manager)?

[ananta, 2010-03-05 20:07:09]

LGTM with Amit's suggestion incorporated.

[stoyan, 2010-03-05 20:18:10]

Sending things with platform dependent size over the wire is not a good idea.

http://codereview.chromium.org/668168/diff/23/27
File chrome_frame/chrome_active_document.cc (right):

http://codereview.chromium.org/668168/diff/23/27#newcode714
chrome_frame/chrome_active_document.cc:714: HRESULT hr =
popup_manager_->EvaluateNewWindow(
On 2010/03/05 19:45:21, amit wrote:
> if (popup_manager)?

Done.