Issue 6709038: Move RenderView to content. I've added a new method to ContentRendererClient to determine the te...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6709038: Move RenderView to content. I've added a new method to ContentRendererClient to determine the te... (Closed)

Created:
9 years, 9 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Move RenderView to content. I've added a new method to ContentRendererClient to determine the text language. This is only temporary, since the surrounding code should itself be moved out of RenderView. TBR=avi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78738

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -6914 lines)			Patch
M	chrome/chrome_renderer.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	3 chunks	+29 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 chunk	+2 lines, -1430 lines	0 comments	Download
D	chrome/renderer/render_view.cc	View	1 chunk	+0 lines, -5450 lines	0 comments	Download
M	content/content_renderer.gypi	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/renderer/content_renderer_client.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/renderer/content_renderer_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	content/renderer/render_view.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/renderer/render_view.cc	View	4 chunks	+3 lines, -29 lines	0 comments	Download

Total messages: 2 (0 generated)

eyeballed, rubber-stamp lgtm