Issue 6799021: Switch from xml.dom.minidom to xml.etree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6799021: Switch from xml.dom.minidom to xml.etree (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Switch from xml.dom.minidom to xml.etree The reason of this change (beside deleting 30 lines) is to fix pylint on Mac. For an unknown reason, it was dying here trying to process the minidom import. [email protected] BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80770

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -119 lines)			Patch
M	fix_encoding.py	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	gclient_utils.py	View	2 chunks	+0 lines, -25 lines	0 comments	Download
M	presubmit_canned_checks.py	View	3 chunks	+24 lines, -8 lines	0 comments	Download
M	rietveld.py	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	scm.py	View	4 chunks	+73 lines, -79 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	tests/scm_unittest.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 8 months ago (2011-04-07 02:09:23 UTC) #3

LGTM.

http://codereview.chromium.org/6799021/diff/1/rietveld.py
File rietveld.py (right):

http://codereview.chromium.org/6799021/diff/1/rietveld.py#newcode37
rietveld.py:37: # Mac pylint chocke on this line.
Nit. "Mac pylint chokes on this line"

Expand Messages | Collapse Messages