Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6909027: Move favicon from TabContents to TabContentsWrapper. (Closed)

Created:
9 years, 7 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
michaelbai, cbentzel, jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move favicon from TabContents to TabContentsWrapper. BUG=71097 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83966

Patch Set 1 #

Patch Set 2 : cleaned up #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -188 lines) Patch
M chrome/browser/aeropeek_manager.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 3 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 3 chunks +91 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 chunks +5 lines, -1 line 1 comment Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 9 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 4 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/web_ui_unittest.cc View 1 10 chunks +19 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 8 chunks +4 lines, -33 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 6 chunks +3 lines, -78 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
michaelbai: for review; you're now the new expert in favicons! :p jam: fyi
9 years, 7 months ago (2011-05-03 18:33:31 UTC) #1
cbentzel
prerender LGTM http://codereview.chromium.org/6909027/diff/2001/chrome/browser/prerender/prerender_manager.cc File chrome/browser/prerender/prerender_manager.cc (right): http://codereview.chromium.org/6909027/diff/2001/chrome/browser/prerender/prerender_manager.cc#newcode428 chrome/browser/prerender/prerender_manager.cc:428: TabContentsWrapper* wrapper = The TODO is fine, ...
9 years, 7 months ago (2011-05-03 18:44:40 UTC) #2
michaelbai
favicon LGTM.
9 years, 7 months ago (2011-05-03 19:13:16 UTC) #3
jam
lgtm can you update content/browser/DEPS? you should be able to remove the two favicon includes
9 years, 7 months ago (2011-05-03 19:14:00 UTC) #4
Avi (use Gerrit)
9 years, 7 months ago (2011-05-03 19:58:55 UTC) #5 
On 2011/05/03 19:14:00, John Abd-El-Malek wrote:
> can you update content/browser/DEPS?

My pleasure! :)

Powered by Google App Engine
This is Rietveld 408576698