Save and restore the value of GetLastError() when [D]LOG/[D]CHECK etc on Wind...

Save and restore the value of GetLastError() when [D]LOG/[D]CHECK etc on Windows.
Also for log levels higher than INFO, the value of GLE is tagged onto the log message.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13667

[brettw, 2009-04-13 20:24:41]

http://codereview.chromium.org/73010/diff/1/2
File base/logging.cc (right):

http://codereview.chromium.org/73010/diff/1/2#newcode432
Line 432: stream_ << StringPrintf(" [le: %i]", last_error_.get_error());
I'm not a fan of this. I've only needed the LastError once or twice in the years
of working on this project, and then I just add it when I need it. It seems like
a lot to make every log message for every developer contain this.

http://codereview.chromium.org/73010/diff/1/3
File base/logging.h (right):

http://codereview.chromium.org/73010/diff/1/3#newcode544
Line 544: class SaveLastError {
Can you write a comment describing what this class does?

http://codereview.chromium.org/73010/diff/1/3#newcode548
Line 548: unsigned long get_error() const { return last_error_; }
Can you put a blank line before this?

[tommi (sloooow) - chröme, 2009-04-13 20:45:15]

http://codereview.chromium.org/73010/diff/1/2
File base/logging.cc (right):

http://codereview.chromium.org/73010/diff/1/2#newcode432
Line 432: stream_ << StringPrintf(" [le: %i]", last_error_.get_error());
On 2009/04/13 20:24:41, brettw wrote:
> I'm not a fan of this. I've only needed the LastError once or twice in the
years
> of working on this project, and then I just add it when I need it. It seems
like
> a lot to make every log message for every developer contain this.

Is there any reason for saving on the error information?  This will likely add
9-10 characters to warnings and errors only.  I can further reduce it by not
adding it if gle is ERROR_SUCCESS.

http://codereview.chromium.org/73010/diff/1/3
File base/logging.h (right):

http://codereview.chromium.org/73010/diff/1/3#newcode544
Line 544: class SaveLastError {
On 2009/04/13 20:24:41, brettw wrote:
> Can you write a comment describing what this class does?

Done.

http://codereview.chromium.org/73010/diff/1/3#newcode548
Line 548: unsigned long get_error() const { return last_error_; }
On 2009/04/13 20:24:41, brettw wrote:
> Can you put a blank line before this?

Done.

[brettw, 2009-04-13 20:52:27]

http://codereview.chromium.org/73010/diff/1/2
File base/logging.cc (right):

http://codereview.chromium.org/73010/diff/1/2#newcode432
Line 432: stream_ << StringPrintf(" [le: %i]", last_error_.get_error());
I look at them in my error log and I already think we have too much useless
information.

[tommi (sloooow) - chröme, 2009-04-13 21:01:44]

http://codereview.chromium.org/73010/diff/1/2
File base/logging.cc (right):

http://codereview.chromium.org/73010/diff/1/2#newcode432
Line 432: stream_ << StringPrintf(" [le: %i]", last_error_.get_error());
On 2009/04/13 20:52:27, brettw wrote:
> I look at them in my error log and I already think we have too much useless
> information.

ok.  what do you say about only doing this for fatal errors?

[darin (slow to review), 2009-04-13 21:32:22]

net> grep -r CHECK . | grep -v \.svn | grep .cc: | wc -l
809
net> grep -r LOG . | grep -v \.svn | grep .cc: | wc -l
202
net> grep -r GetLastError . | grep -v \.svn | grep .cc: | wc -l
41

I think most of our logging is in cross-platform code where GetLastError is not
helpful.  Let's not do this.

[tommi (sloooow) - chröme, 2009-04-14 15:47:38]

lates changes uploaded.  no longer adding anything to the log string. just
saving the last error.

[brettw, 2009-04-14 16:50:58]

LGTM