Removal of Profile from content part 1.

Removal of Profile from content part 1.

BUG=76788
TEST=no change visible

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94317

[Avi (use Gerrit), 2011-07-20 22:35:47]

Sorry I didn't cut it off sooner. The big change is splitting BrowserContext
from Profile and renaming profile() on TC, NC and RPH to context(). The rest is
fallout.

[jam, 2011-07-21 16:41:54]

i think we should differentiate BrowserContext from ResourceContext by always
naming the parameters/getters/variables/comments browser_context instead of
"context"

(I stopped looking after a few files)

http://codereview.chromium.org/7464009/diff/1149/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile.h (right):

http://codereview.chromium.org/7464009/diff/1149/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.h:195: // Begin BrowserContext
------------------------------------------------------
nit: I haven't this style of comments before, usually I see
"content::BrowserContext implementation

http://codereview.chromium.org/7464009/diff/1149/content/browser/browser_cont...
File content/browser/browser_context.h (right):

http://codereview.chromium.org/7464009/diff/1149/content/browser/browser_cont...
content/browser/browser_context.h:5: // This class gathers state related to an
instantiation of content.
nit: "instantiation of content" is a little cryptic

http://codereview.chromium.org/7464009/diff/1149/content/browser/browser_cont...
content/browser/browser_context.h:47: // Returns a pointer to the
DatabaseTracker instance for this profile.
nit: should get rid of "profile" in this file

http://codereview.chromium.org/7464009/diff/1149/content/browser/browser_url_...
File content/browser/browser_url_handler.h (right):

http://codereview.chromium.org/7464009/diff/1149/content/browser/browser_url_...
content/browser/browser_url_handler.h:36: typedef bool (*URLHandler)(GURL* url,
content::BrowserContext* context);
nit: i think we should differentiate BrowserContext from ResourceContext by
always naming the parameters/getters/variables browser_context

[Avi (use Gerrit), 2011-07-21 18:04:25]

Will make the changes you suggest. Are you OK with the approach I'm taking?

[Avi (use Gerrit), 2011-07-21 22:17:34]

Issues addressed.

[Ilya Sherman, 2011-07-21 22:29:23]

A couple of drive-by questions (sorry for being a bit late to jump in here)

http://codereview.chromium.org/7464009/diff/6001/chrome/browser/autofill/auto...
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/7464009/diff/6001/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_manager.cc:699:
static_cast<Profile*>(tab_contents()->browser_context()));
I really don't like that clients need to magically know that this cast is safe. 
If it's always safe, can we just push it into
BrowserList::GetLastActiveWithProfile()?

http://codereview.chromium.org/7464009/diff/6001/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_manager.cc:750: return
profile->GetPrefs()->GetBoolean(prefs::kAutofillEnabled);
Similar question here: Are all clients of GetPrefs() going to need to perform a
static cast?  If it's always safe, can we hide the cast in a wrapper function,
e.g. a static function GetPrefs(tab_contents()->browser_context())?

[Avi (use Gerrit), 2011-07-22 14:56:26]

The cast is always safe, as the only implementation of BrowserContext is ever
going to be Profile. Whether or not we alter ProfileKeyedServiceFactory to allow
looking up by BrowserContext and then retrofit stuff hanging off Profile to be a
PKSF is a different issue.

And it's not just users of GetPrefs but rather anything that hits up anything on
Profile.

[jam, 2011-07-22 16:32:30]

On 2011/07/21 18:04:25, Avi wrote:
> Will make the changes you suggest. Are you OK with the approach I'm taking?

oops sorry I should have been clearer, yes this approach is great :)

[jam, 2011-07-22 16:58:38]

Seeing how many casts there are, what do you think of having a static Profile*
Profile::FromBrowserContext(content::BrowserContext* browser_context) method
that hides this?

http://codereview.chromium.org/7464009/diff/6001/content/browser/browsing_ins...
File content/browser/browsing_instance.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/browsing_ins...
content/browser/browsing_instance.h:70: content::BrowserContext* context() {
return context_; }
nit: browser_context in all this file

http://codereview.chromium.org/7464009/diff/6001/content/browser/content_brow...
File content/browser/content_browser_client.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/content_brow...
content/browser/content_browser_client.h:93: virtual GURL
GetEffectiveURL(BrowserContext* context, const GURL& url) = 0;
nit: browser_context (all this file + mock + chrome impl)

http://codereview.chromium.org/7464009/diff/6001/content/browser/host_zoom_map.h
File content/browser/host_zoom_map.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/host_zoom_ma...
content/browser/host_zoom_map.h:6: // any thread.  One instance per context.
nit: browser context

http://codereview.chromium.org/7464009/diff/6001/content/browser/in_process_w...
File content/browser/in_process_webkit/dom_storage_context.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/in_process_w...
content/browser/in_process_webkit/dom_storage_context.h:27: // shared by all the
DOMStorageMessageFilters that share the same context.  The
nit: browser context

http://codereview.chromium.org/7464009/diff/6001/content/browser/in_process_w...
content/browser/in_process_webkit/dom_storage_context.h:139: // Path where the
context data is stored.
ditto

http://codereview.chromium.org/7464009/diff/6001/content/browser/in_process_w...
File content/browser/in_process_webkit/dom_storage_message_filter.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/in_process_w...
content/browser/in_process_webkit/dom_storage_message_filter.h:83: // Data
shared between renderer processes with the same context.
ditto

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/browser_render_process_host.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/browser_render_process_host.h:45: explicit
BrowserRenderProcessHost(content::BrowserContext* context);
nit: brower_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/pepper_file_message_filter.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/pepper_file_message_filter.h:34:
PepperFileMessageFilter(int child_id, content::BrowserContext* context);
ditto

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.h:73:
content::BrowserContext* context,
ditto

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.h:223:
content::BrowserContext* context_;
ditto

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_process_host.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_process_host.h:75: content::BrowserContext*
context() const { return context_; }
nit: browser_context everywhere in this file

http://codereview.chromium.org/7464009/diff/6001/content/browser/resolve_prox...
File content/browser/resolve_proxy_msg_helper.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/resolve_prox...
content/browser/resolve_proxy_msg_helper.h:30: // If |proxy_service| is NULL,
then the main context's proxy service will
ditto

http://codereview.chromium.org/7464009/diff/6001/content/browser/site_instance.h
File content/browser/site_instance.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/site_instanc...
content/browser/site_instance.h:122: static SiteInstance*
CreateSiteInstance(content::BrowserContext* context);
browser_context in all this file

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
File content/browser/tab_contents/interstitial_page.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
content/browser/tab_contents/interstitial_page.h:131: content::BrowserContext*
context) const OVERRIDE;
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
File content/browser/tab_contents/render_view_host_manager.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
content/browser/tab_contents/render_view_host_manager.h:93: void
Init(content::BrowserContext* context,
nit: browsr_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
content/browser/tab_contents/tab_contents.cc:125: content::BrowserContext*
context, const NavigationEntry& entry,
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
File content/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
content/browser/tab_contents/tab_contents.h:105: // Returns the user context
associated with this TabContents (via the
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
content/browser/tab_contents/tab_contents.h:673: content::BrowserContext*
context) const OVERRIDE;
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
File content/browser/tab_contents/tab_contents_delegate.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/tab_contents...
content/browser/tab_contents/tab_contents_delegate.h:218: virtual void
ShowPageInfo(content::BrowserContext* context,
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/webui/empty_...
File content/browser/webui/empty_web_ui_factory.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/webui/empty_...
content/browser/webui/empty_web_ui_factory.h:21: virtual WebUI::TypeID
GetWebUIType(content::BrowserContext* context,
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/webui/web_ui...
File content/browser/webui/web_ui_factory.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/webui/web_ui...
content/browser/webui/web_ui_factory.h:30: virtual WebUI::TypeID
GetWebUIType(content::BrowserContext* context,
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/worker_host/...
File content/browser/worker_host/worker_process_host.h (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/worker_host/...
content/browser/worker_host/worker_process_host.h:29: // net::URLRequestContext)
that a WorkerProcessHost serves a single context.
nit: browser_context

http://codereview.chromium.org/7464009/diff/6001/content/browser/worker_host/...
File content/browser/worker_host/worker_service.cc (right):

http://codereview.chromium.org/7464009/diff/6001/content/browser/worker_host/...
content/browser/worker_host/worker_service.cc:225: // on behalf of a single
context. The process sharing logic below
nit: browser_context

[jam, 2011-07-27 17:15:33]

lgtm!

http://codereview.chromium.org/7464009/diff/20001/content/browser/browser_con...
File content/browser/browser_context.h (right):

http://codereview.chromium.org/7464009/diff/20001/content/browser/browser_con...
content/browser/browser_context.h:5: // This class holds the context needed for
a browsing session.
nit: do we have a convention over whether the comment for a class is at the top
after the copyright, or right above the class name? I personally find the latter
easier to find.

[Avi (use Gerrit), 2011-07-27 17:40:10]

Miranda: please review profile changes as OWNER

http://codereview.chromium.org/7464009/diff/20001/content/browser/browser_con...
File content/browser/browser_context.h (right):

http://codereview.chromium.org/7464009/diff/20001/content/browser/browser_con...
content/browser/browser_context.h:5: // This class holds the context needed for
a browsing session.
On 2011/07/27 17:15:34, John Abd-El-Malek wrote:
> nit: do we have a convention over whether the comment for a class is at the
top
> after the copyright, or right above the class name? I personally find the
latter
> easier to find.

Done.

[Miranda Callahan, 2011-07-27 17:46:13]

LGTM Profile changes!

On 2011/07/27 17:40:10, Avi wrote:
> Miranda: please review profile changes as OWNER
> 
>
http://codereview.chromium.org/7464009/diff/20001/content/browser/browser_con...
> File content/browser/browser_context.h (right):
> 
>
http://codereview.chromium.org/7464009/diff/20001/content/browser/browser_con...
> content/browser/browser_context.h:5: // This class holds the context needed
for
> a browsing session.
> On 2011/07/27 17:15:34, John Abd-El-Malek wrote:
> > nit: do we have a convention over whether the comment for a class is at the
> top
> > after the copyright, or right above the class name? I personally find the
> latter
> > easier to find.
> 
> Done.