Cleanup SSLConfigServiceManager[Pref]

Cleanup SSLConfigServiceManager[Pref]

- Don't use g_browser_process, use BrowserThread::PostTask to send to the IO thread
- Explicitly register LocalState preferences at the appropriate time, rather than deferring registration until the first time the SSLConfigServicePref is used

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93776

[Ryan Sleevi, 2011-07-22 04:50:33]

battre: Prefs
willchan: BrowserThread

battre: The pref changes are just the RegisterPrefs comments you brought up on
http://codereview.chromium.org/7462008/, split into their own CL for cleanup
pruposes.

willchan: While writing a unit test for the above CL, I was running into trouble
with g_browser_process and reliably/cleaning testing it. cpu pointed out that he
was 83% sure that this code should be using BrowserThread, rather than grabbing
the g_browser_process.

As the BrowserThread/IOThread expert-in-residence, I just wanted to make sure
that the usages are equivalent. As far as I can tell, there shouldn't be any
specific reason to use g_browser_process over BrowserThread::PostTask. I'm not
clear if the DCHECK() is strictly necessary, but at the risk of copy pasta, it
matches the other locations observing notifications.

[battre, 2011-07-22 08:24:02]

LGTM for prefs

[willchan no longer on Chromium, 2011-07-22 12:51:30]

cpu is right. LGTM.