Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 7497030: PluginList cleanup (Closed)

Created:
9 years, 5 months ago by Bernhard Bauer
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, pam+watch_chromium.org, kkania, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

PluginList cleanup to fix a race condition and decrease the API surface for future refactorings: * Remove "webkit/glue/plugins/plugin_list.h" includes in favor of "webkit/npapi/plugins/plugin_list.h" * Remove |refresh| parameter from |GetPlugins| in favor of calling |RefreshPlugins| beforehand. * Remove |GetPluginInfo| in favor of calling |GetPluginInfoArray| and looking for the first enabled plug-in. * Remove |GetEnabledPlugins| in favor of calling |GetPlugins| and filtering out disabled plugins. * Remove |stale| in favor of an outparameter to |GetPluginInfoArray|, to remove the race condition. BUG=69516, 80794 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94641

Patch Set 1 #

Patch Set 2 : fix test_shell_tests #

Patch Set 3 : cleanup #

Patch Set 4 : fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -183 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_data_remover.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/plugin_data_remover_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/drag_util.mm View 1 2 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_service.cc View 1 2 3 3 chunks +15 lines, -4 lines 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 2 chunks +14 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 1 chunk +14 lines, -8 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 4 chunks +6 lines, -17 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 1 6 chunks +12 lines, -54 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 1 6 chunks +9 lines, -47 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/support/webkit_support_glue.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bernhard Bauer
Please review.
9 years, 4 months ago (2011-07-28 13:23:13 UTC) #1
jam
lgtm with one caveat: It's a bit awkward for a lot of code that just ...
9 years, 4 months ago (2011-07-28 20:34:08 UTC) #2
Bernhard Bauer
9 years, 4 months ago (2011-07-28 22:53:48 UTC) #3
On Thu, Jul 28, 2011 at 22:34,  <[email protected]> wrote:
> lgtm with one caveat:
>
> It's a bit awkward for a lot of code that just wants the first enabled
> plugin to
> now get the array and look for it. Since you'll need a function in chrome
> that
> does this later and uses profile, why not add it now?

To keep this CL manageable? :-) I already have two other CLs pipelined
which do that (http://codereview.chromium.org/7387010/ and
http://codereview.chromium.org/7477044/), and tried to focus on the
PluginList changes in this one.

> http://codereview.chromium.org/7497030/
>

Powered by Google App Engine
This is Rietveld 408576698