Issue 7819006: Parse and show CWS data (reviews, number of users) in the inline install dialog.

Issue 7819006: Parse and show CWS data (reviews, number of users) in the inline install dialog. (Closed)

Created:
9 years, 3 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 3 months ago

Reviewers:
Elliot Glaysher, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Parse and show CWS data (reviews, number of users) in the inline install dialog. Data is put into a ExtensionInstallUI::Prompt struct that is passed to ShowExtensionInstallDialog implementations (currently only the GTK one actually displays it). Ratings are shown as stars (resources were r99027). The dialog also includes a CWS link for the item (this necessitated switching the GTK implementation to a class so that the click handler callback could get at the delegate and extension). [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99205

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback and fix trybots #

Patch Set 3 : Make destructor virtual #

Patch Set 4 : Fix extension_install_dialog_controller_unittest.mm. #

Patch Set 5 : More extension_install_dialog_controller_unittest.mm fixes; remove lock icon. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+394 lines, -206 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+13 lines, -0 lines	0 comments	Download
D	chrome/app/theme/extensions_permissions_lock.png	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_dialog.h	View		1 chunk	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_dialog.cc	View	1	2 chunks	+16 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.h	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	1	4 chunks	+14 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer.cc	View	1	3 chunks	+34 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm	View	1	4 chunks	+16 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm	View	1 2 3 4	6 chunks	+40 lines, -40 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc	View	1 2 3 4	5 chunks	+200 lines, -102 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View		10 chunks	+16 lines, -20 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webstore_inline_install/detail/ecglahbcnmdpdciemllbhojghbkagdje	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

LGTM. Note that I am not qualified to review the GTK changes, so you should ...

9 years, 3 months ago (2011-08-31 22:06:14 UTC) #2

Mihai Parparita -not on Chrome

+Elliot to review the GTK bits http://codereview.chromium.org/7819006/diff/1/chrome/browser/extensions/extension_install_dialog.cc File chrome/browser/extensions/extension_install_dialog.cc (right): http://codereview.chromium.org/7819006/diff/1/chrome/browser/extensions/extension_install_dialog.cc#newcode37 chrome/browser/extensions/extension_install_dialog.cc:37: On 2011/08/31 22:06:14, ...

9 years, 3 months ago (2011-08-31 22:53:00 UTC) #3

Elliot Glaysher

Under what circumstances will the stars show? I patched it in locally and didn't see ...

9 years, 3 months ago (2011-08-31 23:33:11 UTC) #4

Mihai Parparita -not on Chrome

On 2011/08/31 23:33:11, Elliot Glaysher wrote: > Under what circumstances will the stars show? I ...

9 years, 3 months ago (2011-08-31 23:35:24 UTC) #5

Elliot Glaysher

9 years, 3 months ago (2011-08-31 23:36:39 UTC) #6

ok lgtm

On Wed, Aug 31, 2011 at 4:35 PM,  <[email protected]> wrote:
> On 2011/08/31 23:33:11, Elliot Glaysher wrote:
>>
>> Under what circumstances will the stars show? I patched it in locally and
>
> didn't
>>
>> see them.
>
> Only for inline installs. You can test this by running Chrome with
> --enable-inline-webstore-install
>
--apps-gallery-url=http://persistent.info/webkit/test-cases/inline-store-install/
> and then using the install buttons on
>
http://persistent.info/webkit/test-cases/inline-store-install/tests/docs-fake...
> and
>
http://persistent.info/webkit/test-cases/inline-store-install/tests/tawaft-fa....
>
> http://codereview.chromium.org/7819006/
>

Expand Messages | Collapse Messages