Issue 7887018: Make inline install handle inline_install_not_supported CWS responses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7887018: Make inline install handle inline_install_not_supported CWS responses. (Closed)

Created:
9 years, 3 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 3 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make inline install handle inline_install_not_supported CWS responses. BUG=96329 [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101099

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -4 lines)			Patch
M	chrome/browser/extensions/webstore_inline_install_browsertest.cc	View	1 chunk	+17 lines, -0 lines	1 comment	Download
M	chrome/browser/extensions/webstore_inline_installer.cc	View	3 chunks	+31 lines, -4 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webstore_inline_install/inlineinstall/detail/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webstore_inline_install/install-not-supported.html	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

9 years, 3 months ago (2011-09-14 16:56:04 UTC) #2

LGTM

http://codereview.chromium.org/7887018/diff/1/chrome/browser/extensions/webst...
File chrome/browser/extensions/webstore_inline_install_browsertest.cc (right):

http://codereview.chromium.org/7887018/diff/1/chrome/browser/extensions/webst...
chrome/browser/extensions/webstore_inline_install_browsertest.cc:169:
EXPECT_EQ(GURL("http://cws.com/show-me-the-money"), tab_contents->GetURL());
nice URL

Expand Messages | Collapse Messages