Add GN files for src/win8.

Add GN files for src/win8.

Committed: https://crrev.com/88ed6f4308db37639bbeb30adbf2f62844ead716
Cr-Commit-Position: refs/heads/master@{#312036}

[Slava Chigrin, 2014-12-23 12:36:28]

[email protected] changed reviewers:
+ [email protected], [email protected]

[Slava Chigrin, 2014-12-23 12:40:19]

https://codereview.chromium.org/796903004/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/796903004/diff/1/ash/BUILD.gn#newcode183
ash/BUILD.gn:183: "//ui/metro_viewer",
Seems, this target already added to the GN build. See 
https://code.google.com/p/chromium/codesearch#chromium/src/ui/metro_viewer/BU...

[Slava Chigrin, 2015-01-12 09:57:23]

Please, take a look. Thank you in advance!

[Slava Chigrin, 2015-01-13 10:46:40]

[email protected] changed reviewers:
+ [email protected], [email protected]

[ananta, 2015-01-13 22:02:50]

On 2015/01/13 10:46:51, Slava Chigrin wrote:

Looks good. Were you planning to add in the metro_driver related files later?

[Slava Chigrin, 2015-01-14 07:38:30]

On 2015/01/13 22:02:50, ananta wrote:
> On 2015/01/13 10:46:51, Slava Chigrin wrote:
> 
> Looks good. Were you planning to add in the metro_driver related files later?

Yes, I think do it later as separate CL, if this is acceptable.

[cpu_(ooo_6.6-7.5), 2015-01-15 03:48:29]

seems right except that I don't know about two places. Brettw? Dirk?

https://codereview.chromium.org/796903004/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/796903004/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:655: "//win8:metro_viewer",
not sure about this one.

https://codereview.chromium.org/796903004/diff/1/ui/shell_dialogs/BUILD.gn
File ui/shell_dialogs/BUILD.gn (right):

https://codereview.chromium.org/796903004/diff/1/ui/shell_dialogs/BUILD.gn#ne...
ui/shell_dialogs/BUILD.gn:66: }
or this.

[Dirk Pranke, 2015-01-15 17:53:29]

[email protected] changed reviewers:
+ [email protected]

[Dirk Pranke, 2015-01-15 17:53:30]

This mostly looks right. I've noted a couple things, below.

https://codereview.chromium.org/796903004/diff/1/win8/BUILD.gn
File win8/BUILD.gn (right):

https://codereview.chromium.org/796903004/diff/1/win8/BUILD.gn#newcode5
win8/BUILD.gn:5: static_library("metro_viewer_constants") {
Is there a reason this is a static_library instead of a source_set ?

https://codereview.chromium.org/796903004/diff/1/win8/BUILD.gn#newcode6
win8/BUILD.gn:6: include_dirs = [ ".." ]
".." refers to src/, right? Why would we need to include that in include_dirs?

https://codereview.chromium.org/796903004/diff/1/win8/BUILD.gn#newcode49
win8/BUILD.gn:49: include_dirs = [ ".." ]
same comment ...

[Dirk Pranke, 2015-01-15 18:03:11]

Oh, and make sure you re-run the win_chromium_gn_rel tryjob; I'm guessing that
it got aborted in a tryserver restart at some point.

[Slava Chigrin, 2015-01-15 19:01:49]

Thank you for review, I've fixed issues, tryjobs passed. Sorry for a bit stupid
mistakes, I am only beginner in GN...

[Dirk Pranke, 2015-01-15 20:11:38]

On 2015/01/15 19:01:49, Slava Chigrin wrote:
> Thank you for review, I've fixed issues, tryjobs passed. Sorry for a bit
stupid
> mistakes, I am only beginner in GN...

No problem. There are very few people who aren't beginners in GN :).

lgtm.

[Slava Chigrin, 2015-01-15 20:18:51]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-01-15 20:19:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796903004/20001

[commit-bot: I haz the power, 2015-01-15 20:26:09]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2015-01-15 20:26:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cpu_(ooo_6.6-7.5), 2015-01-17 00:25:10]

lgtm

[cpu_(ooo_6.6-7.5), 2015-01-17 00:25:14]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-01-17 00:26:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796903004/20001

[commit-bot: I haz the power, 2015-01-17 00:27:24]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2015-01-17 00:27:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Slava Chigrin, 2015-01-17 11:55:41]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-01-17 11:56:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796903004/20001

[commit-bot: I haz the power, 2015-01-17 11:57:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-17 11:58:16]

Patchset 2 (id:??) landed as
https://crrev.com/88ed6f4308db37639bbeb30adbf2f62844ead716
Cr-Commit-Position: refs/heads/master@{#312036}