Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800853004: Update PermissionContextBaseTests for permission bubble (Closed)

Created:
6 years ago by felt
Modified:
6 years ago
Reviewers:
markusheintz_
CC:
chromium-reviews, markusheintz_, Greg Billock
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update PermissionContextBaseTests for permission bubble This makes the PermissionContextBaseTests tests work both with and without the permission bubble, in preparation for flipping the flag. Supercedes https://codereview.chromium.org/411503005/ BUG=438758 Committed: https://crrev.com/88bf98cbe6fe34e681dbd82b2cc61e84c87dfc15 Cr-Commit-Position: refs/heads/master@{#308522}

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 4

Patch Set 3 : Fix rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -69 lines) Patch
M chrome/browser/content_settings/permission_context_base_unittest.cc View 1 2 3 chunks +108 lines, -68 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
felt
Markus, PTAL.
6 years ago (2014-12-13 17:31:03 UTC) #2
markusheintz_
LGTM https://codereview.chromium.org/800853004/diff/20001/chrome/browser/content_settings/permission_context_base_unittest.cc File chrome/browser/content_settings/permission_context_base_unittest.cc (right): https://codereview.chromium.org/800853004/diff/20001/chrome/browser/content_settings/permission_context_base_unittest.cc#newcode102 chrome/browser/content_settings/permission_context_base_unittest.cc:102: CONTENT_SETTINGS_TYPE_PUSH_MESSAGING); nit: please fix indentation. https://codereview.chromium.org/800853004/diff/20001/chrome/browser/content_settings/permission_context_base_unittest.cc#newcode130 chrome/browser/content_settings/permission_context_base_unittest.cc:130: CONTENT_SETTINGS_TYPE_NOTIFICATIONS); ...
6 years ago (2014-12-15 13:14:33 UTC) #3
felt
https://codereview.chromium.org/800853004/diff/20001/chrome/browser/content_settings/permission_context_base_unittest.cc File chrome/browser/content_settings/permission_context_base_unittest.cc (right): https://codereview.chromium.org/800853004/diff/20001/chrome/browser/content_settings/permission_context_base_unittest.cc#newcode102 chrome/browser/content_settings/permission_context_base_unittest.cc:102: CONTENT_SETTINGS_TYPE_PUSH_MESSAGING); On 2014/12/15 13:14:33, markusheintz_ wrote: > nit: please ...
6 years ago (2014-12-16 02:57:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800853004/40001
6 years ago (2014-12-16 02:57:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-16 03:50:31 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-16 03:51:48 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/88bf98cbe6fe34e681dbd82b2cc61e84c87dfc15
Cr-Commit-Position: refs/heads/master@{#308522}

Powered by Google App Engine
This is Rietveld 408576698