Implementation of ppapi audio.

Microphone support for Pepper Flash.

This change supports audio capture from the microphone and supplies the data
through a Pepper interface. Its enumeration is limited to the default audio
device that uses mono 44.1kHz.

[ilja, 2011-10-11 21:17:03]

There are two places where you picked up stuff from other changes. Please clean
these up. Otherwise it looks reasonable. We have to test it a bit once it is
ready. Otherwise Chromium enforces 80 characters per line pretty hard. You will
notice all Lint warnings. You will have to address them, should not be too hard.

http://codereview.chromium.org/8138008/diff/23001/ppapi/thunk/interfaces_ppb_...
File ppapi/thunk/interfaces_ppb_public_dev.h (right):

http://codereview.chromium.org/8138008/diff/23001/ppapi/thunk/interfaces_ppb_...
ppapi/thunk/interfaces_ppb_public_dev.h:50: UNPROXIED_IFACE(PPB_Instance,
PPB_QUERYPOLICY_DEV_INTERFACE_0_1,
You picked up changes that are not yours.

http://codereview.chromium.org/8138008/diff/23001/ppapi/thunk/interfaces_ppb_...
ppapi/thunk/interfaces_ppb_public_dev.h:56: PPB_Scrollbar_Dev)
Dito.

[brettw, 2011-10-12 19:33:13]

Just poking at it, I noticed a few spacing nits. Sending these separately before
I start looking at the real logic.

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
File content/renderer/pepper_plugin_delegate_impl.cc (right):

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:360:
webkit::ppapi::PluginDelegate::PlatformAudioInput::Client* client);
Should be indented only 4 spaces

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:459: const AudioParameters&
params) {
Only 4 space indent.

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:1167: audio_input(new
PlatformAudioInputImpl());
4 space indent.

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_input_impl.cc (right):

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_input_impl.cc:54: PPB_AudioInput_Callback
audio_input_callback,
Since these don't fit, move all the args to 4 space indents (even the instance
once -- move it to the next line).

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_input_impl.cc:57: audio_input(new
PPB_AudioInput_Impl(instance));
4 space.

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_input_impl.cc:104: PP_CompletionCallback
create_callback) {
4 space indent.

[brettw, 2011-10-12 20:39:34]

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
File content/renderer/pepper_plugin_delegate_impl.cc (right):

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:382: //TODO(peterb) need to add
This should be cleaned up or clarified.

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:410: //TODO(peterb) figure out
the params to use
Did you figure out the proper params? Can this be finalized now and your
comments deleted?

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:428: if (filter_) {
I don't think this can be NULL. I notice the existing output API checks for NULL
in some cases and doesn't in others. I wonder if the checking code is either
wrong or obsolete. Unless you know of a reason why this can be NULL, let's
remove the checks and assume it's always non-NULL.

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:488: base::SharedMemoryHandle
handle, base::SyncSocket::Handle socket_handle,
Style nit: I usually try to put each param on a separate line when I'm using
multiple lines like this, so maybe put socket_handle on its own line?

http://codereview.chromium.org/8138008/diff/31007/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:1172: } else {
I'd just delete this else condition and use the return NULL at the outer scope.

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_input_impl.cc (right):

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_input_impl.cc:124: int32_t
PPB_AudioInput_Impl::GetSyncSocket(int* sync_socket) {
These 3 functions are exactly copied from audio output, and it's not exactly the
simplest code ever. I wonder if we can factor this somehow to share this code.
Like maybe have an AudioShared helper class that implements this stuff?

The calls on these functions will still be coming in on different interfaces,
and it may not make sense to share a base class (for the *_API classes). Maybe
we can have a helper class that becomes a member (rather than a base class so
the inheritance and different-but-identically-named functions don't get too
crazy) that manages the handles, completion callback, and sockets for these two
audio classes?

[seriesrover, 2011-10-12 22:57:09]

> webkit/plugins/ppapi/ppb_audio_input_impl.cc:124: int32_t
> PPB_AudioInput_Impl::GetSyncSocket(int* sync_socket) {
> These 3 functions are exactly copied from audio output, and it's not exactly
the
> simplest code ever. I wonder if we can factor this somehow to share this code.
> Like maybe have an AudioShared helper class that implements this stuff?
> 
> The calls on these functions will still be coming in on different interfaces,
> and it may not make sense to share a base class (for the *_API classes). Maybe
> we can have a helper class that becomes a member (rather than a base class so
> the inheritance and different-but-identically-named functions don't get too
> crazy) that manages the handles, completion callback, and sockets for these
two
> audio classes?

I quite agree, we should re-factor this.  I suggest we push it back until after
the branch?  Theres some device management (for audio + video) that needs to
added to pepper; this re-factoring could be bucketed with that.

[brettw, 2011-10-14 20:32:52]

Since it seems like we agreed this won't make the branch, let's refactor now, it
should be easy.

[viettrungluu, 2011-11-02 21:03:07]

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_input_impl.cc (right):

http://codereview.chromium.org/8138008/diff/31007/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_input_impl.cc:124: int32_t
PPB_AudioInput_Impl::GetSyncSocket(int* sync_socket) {
What Brett said here still applies, and his response to pushing out the
refactoring also still applies.

On 2011/10/12 20:39:34, brettw wrote:
> These 3 functions are exactly copied from audio output, and it's not exactly
the
> simplest code ever. I wonder if we can factor this somehow to share this code.
> Like maybe have an AudioShared helper class that implements this stuff?
> 
> The calls on these functions will still be coming in on different interfaces,
> and it may not make sense to share a base class (for the *_API classes). Maybe
> we can have a helper class that becomes a member (rather than a base class so
> the inheritance and different-but-identically-named functions don't get too
> crazy) that manages the handles, completion callback, and sockets for these
two
> audio classes?

[seriesrover, 2011-11-03 16:03:02]

Yup, and I've got that as a todo - shouldn't take long.

Patch Set 9 added in the AudioConfig for AudioInput + minor cleanup - other than
the refactoring is there any other feedback from the review that needs
addressing?

[viettrungluu, 2011-11-08 00:41:54]

Some more comments....

http://codereview.chromium.org/8138008/diff/59013/content/renderer/pepper_plu...
File content/renderer/pepper_plugin_delegate_impl.cc (right):

http://codereview.chromium.org/8138008/diff/59013/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:38: #include
"content/renderer/media/audio_input_message_filter.h"
Nit: alphabetical order

http://codereview.chromium.org/8138008/diff/59013/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:428: FROM_HERE,
Nit: incorrect indentation.

http://codereview.chromium.org/8138008/diff/59013/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:436: FROM_HERE,
"

http://codereview.chromium.org/8138008/diff/59013/content/renderer/pepper_plu...
content/renderer/pepper_plugin_delegate_impl.cc:1162: audio_input(new
PlatformAudioInputImpl());
nit: incorrect indentation

http://codereview.chromium.org/8138008/diff/59013/ppapi/c/dev/ppb_audio_input...
File ppapi/c/dev/ppb_audio_input_dev.h (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/c/dev/ppb_audio_input...
ppapi/c/dev/ppb_audio_input_dev.h:1: /* Copyright (c) 2011 The Chromium Authors.
All rights reserved.
At this point in time, please write an .idl file and generate this file.

http://codereview.chromium.org/8138008/diff/59013/ppapi/c/trusted/ppb_audio_i...
File ppapi/c/trusted/ppb_audio_input_trusted_dev.h (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/c/trusted/ppb_audio_i...
ppapi/c/trusted/ppb_audio_input_trusted_dev.h:1: /* Copyright (c) 2011 The
Chromium Authors. All rights reserved.
"

http://codereview.chromium.org/8138008/diff/59013/ppapi/ppapi_shared.gypi
File ppapi/ppapi_shared.gypi (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/ppapi_shared.gypi#new...
ppapi/ppapi_shared.gypi:97: 'thunk/ppb_audio_input_api.h',
nit: alphabetical order

http://codereview.chromium.org/8138008/diff/59013/ppapi/proxy/interface_list.cc
File ppapi/proxy/interface_list.cc (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/proxy/interface_list....
ppapi/proxy/interface_list.cc:57: #include "ppapi/proxy/ppb_audio_input_proxy.h"
nit: alphabetical order

http://codereview.chromium.org/8138008/diff/59013/ppapi/proxy/ppb_audio_input...
File ppapi/proxy/ppb_audio_input_proxy.cc (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/proxy/ppb_audio_input...
ppapi/proxy/ppb_audio_input_proxy.cc:339: 
nit: remove extra blank line

http://codereview.chromium.org/8138008/diff/59013/ppapi/thunk/resource_creati...
File ppapi/thunk/resource_creation_api.h (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/thunk/resource_creati...
ppapi/thunk/resource_creation_api.h:15: #include
"ppapi/c/dev/ppb_audio_input_dev.h"
nit: alphabetical order

http://codereview.chromium.org/8138008/diff/59013/ppapi/thunk/thunk.h
File ppapi/thunk/thunk.h (right):

http://codereview.chromium.org/8138008/diff/59013/ppapi/thunk/thunk.h#newcode31
ppapi/thunk/thunk.h:31: struct PPB_AudioInputTrusted_Dev;
nit: alphabetical order

http://codereview.chromium.org/8138008/diff/59013/ppapi/thunk/thunk.h#newcode56
ppapi/thunk/thunk.h:56: PPAPI_THUNK_EXPORT const PPB_AudioInputTrusted_Dev*
"

http://codereview.chromium.org/8138008/diff/59013/webkit/glue/webkit_glue.gypi
File webkit/glue/webkit_glue.gypi (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/glue/webkit_glue.gyp...
webkit/glue/webkit_glue.gypi:225: '../plugins/ppapi/ppb_audio_input_impl.cc',
"

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/audio_...
File webkit/plugins/ppapi/audio_helper.cc (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/audio_...
webkit/plugins/ppapi/audio_helper.cc:13: // AudioHelper
---------------------------------------------------------
nit: fill -s to 80 columns

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/audio_...
File webkit/plugins/ppapi/audio_helper.h (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/audio_...
webkit/plugins/ppapi/audio_helper.h:23: explicit AudioHelper();
No |explicit|.

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/audio_...
webkit/plugins/ppapi/audio_helper.h:27: virtual int32_t GetSyncSocket(int*
sync_socket) OVERRIDE;
No OVERRIDEs.

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/audio_...
webkit/plugins/ppapi/audio_helper.h:41: private:
indentation

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
File webkit/plugins/ppapi/plugin_delegate.h (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_delegate.h:220: 
nit: remove extra blank line

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_delegate.h:249: 
nit: remove extra blank lines

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_delegate.h:324: uint32_t sample_count,
nit: indentation

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_module.cc:78: #include
"ppapi/c/trusted/ppb_audio_input_trusted_dev.h"
alphabetical order

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_module.cc:255: if (strcmp(name,
PPB_AUDIO_INPUT_TRUSTED_DEV_INTERFACE) == 0)
"

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_impl.cc (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:144: uint32_t* shm_size) {
indentation

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:156: base::SharedMemoryHandle
shared_memory_handle,
indentation

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_impl.h (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.h:32: public AudioHelper {
I'm pretty sure that adding yet another superclass isn't a good idea. Could you
make it a member instead?

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_input_impl.h (right):

http://codereview.chromium.org/8138008/diff/59013/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_input_impl.h:65: private:
indentation

[seriesrover, 2011-11-08 04:08:46]

AudioHelper class: making it a member is going to be tricky since there isn't a
shared base class we can hook into (for the callbacks), unless we make
PPB_AudioInput_API and PPB_Audio_API derive from a base class, right?  At that
point we getting into further design and we could refactor a fair amount more
than what I've done here.

I think what is here serves a good purpose for Mic support; then afterwards
create a task to consolidate it further if we choose - it may be possible to add
webcam support in too, but I haven't looked at that for a while to see if it
makes sense.

[viettrungluu, 2011-11-10 19:31:57]

At this point, the headers under ppapi/c really should be generated from .idl
files.

(Tests are also needed, but I'm willing to wait on that.)

http://codereview.chromium.org/8138008/diff/69011/ppapi/proxy/ppb_audio_input...
File ppapi/proxy/ppb_audio_input_proxy.h (right):

http://codereview.chromium.org/8138008/diff/69011/ppapi/proxy/ppb_audio_input...
ppapi/proxy/ppb_audio_input_proxy.h:31: PPB_AudioInput_Proxy(Dispatcher*
dispatcher);
explicit

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/audio_...
File webkit/plugins/ppapi/audio_helper.cc (right):

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/audio_...
webkit/plugins/ppapi/audio_helper.cc:13: // AudioHelper
------------------------------------------------
nit: fill to 80 columns

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/ppb_au...
File webkit/plugins/ppapi/ppb_audio_impl.cc (right):

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:140: return
AudioHelper::GetSyncSocket(sync_socket);
nit: incorrect indentation

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:145: return
AudioHelper::GetSharedMemory(shm_handle, shm_size);
"

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:152: SetStreamInfo(shared_memory_handle,
shared_memory_size, socket_handle);
"

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:159: StreamCreated_(shared_memory_handle,
shared_memory_size, socket_handle);
"

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/ppb_au...
webkit/plugins/ppapi/ppb_audio_impl.cc:164: 
no need to add extraneous blank lines

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/resour...
File webkit/plugins/ppapi/resource_creation_impl.h (right):

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/resour...
webkit/plugins/ppapi/resource_creation_impl.h:37: PP_Resource config_id,
align

http://codereview.chromium.org/8138008/diff/69011/webkit/plugins/ppapi/resour...
webkit/plugins/ppapi/resource_creation_impl.h:38: PPB_AudioInput_Callback
audio_input_callback,
or, since it won't fit, move the first argument to a line of its own and
double-indent (4 spaces) all the arguments

[viettrungluu, 2011-11-10 21:05:12]

I meant to add: Otherwise, it looks okay. But it needs to be rebased, run
through the trybots, etc.

Also, please update the title/description of this code review to something
sensible.

[seriesrover, 2011-11-15 04:52:48]

So Ilja and I have cleaned up and synced to top of tree; created the .idl for
both the audio input and trusted interfaces.  We've done some very basic testing
with an audio/webcam test page that records video mail [worked].  Have also
tested with Adobe Connect [web presentation tool] to hear microphone.

Testing has been limited to Linux; Ilja is currently building a ChromeOS binary.
 We need to do further testing in the next couple of days.

[viettrungluu, 2011-11-15 06:16:42]

I'll take another look tomorrow and try to get it landed.

In terms of testing, we require automated tests; see the existing tests under
ppapi/tests.

On 2011/11/15 04:52:48, seriesrover wrote:
> So Ilja and I have cleaned up and synced to top of tree; created the .idl for
> both the audio input and trusted interfaces.  We've done some very basic
testing
> with an audio/webcam test page that records video mail [worked].  Have also
> tested with Adobe Connect [web presentation tool] to hear microphone.
> 
> Testing has been limited to Linux; Ilja is currently building a ChromeOS
binary.
>  We need to do further testing in the next couple of days.

[ilja, 2011-11-15 20:13:55]

I had linking problems when building Chrome in CrOS. They went away after adding
OVERRIDE to ppb_audio_input_proxy.cc and ppb_audio_input_impl.h (mostly on the
AsPPB_AudioInput_API()) and wiping all previous object files to get a clean
build.

[viettrungluu, 2011-11-16 01:08:33]

Mostly LGTM. I patched it in and uploaded it as
http://codereview.chromium.org/8138008/ .

- I made a bunch of style/whitespace fixes (patch set 2).
- I'll clean up the AudioHelper and ...::Client stuff tomorrow.

Thanks.

http://codereview.chromium.org/8138008/diff/91007/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

http://codereview.chromium.org/8138008/diff/91007/ppapi/proxy/ppapi_messages....
ppapi/proxy/ppapi_messages.h:196: IPC_MESSAGE_CONTROL2(PpapiMsg_ExecuteCallback,
Eh?

http://codereview.chromium.org/8138008/diff/91007/webkit/plugins/ppapi/plugin...
File webkit/plugins/ppapi/plugin_delegate.h (right):

http://codereview.chromium.org/8138008/diff/91007/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_delegate.h:227: virtual void
StreamCreated(base::SharedMemoryHandle shared_memory_handle,
I'm going to refactor this to get rid of the StreamCreate_ stuff. Probably both
PlatformAudio and PlatformAudioInput will just share a PlatformAudioCommonClient
(or whatever I decide to call it), and then the AudioHelper will become an Impl.
Probably OnSetStreamInfo() will figure into this somehow too.

[ilja, 2011-11-16 01:41:03]

http://codereview.chromium.org/8574029/