Issue 81563003: AppListPositioner unit tests: Actually use the PlaceShelf abstraction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81563003: AppListPositioner unit tests: Actually use the PlaceShelf abstraction. (Closed)

Created:
7 years, 1 month ago by Matt Giuca

Modified:
7 years, 1 month ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

AppListPositioner unit tests: Actually use the PlaceShelf abstraction. This method was built in the previous CL but not used due to oversight. :( BUG=317944 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236710

Patch Set 1 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
	M	chrome/browser/ui/app_list/app_list_positioner_unittest.cc	View		9 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/81563003/30001

7 years, 1 month ago (2013-11-22 04:07:41 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=193729

7 years, 1 month ago (2013-11-22 06:01:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/81563003/30001

7 years, 1 month ago (2013-11-22 06:32:18 UTC) #5

Message was sent while issue was closed.

Change committed as 236710

Expand Messages | Collapse Messages