Issue 8191: Port some unit tests in chrome/browser/...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8191: Port some unit tests in chrome/browser/... (Closed)

Created:
12 years, 1 month ago by please use my chromium address

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Dean McNamee, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Port some unit tests in chrome/browser/ This first requires http://codereview.chromium.org/8618 . Only snippet_unittest is enabled for build. For rest of files it's only a platform cleanup.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -39 lines)			Patch
M	chrome/browser/history/query_parser_unittest.cc	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/snippet_unittest.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/text_database_manager_unittest.cc	View	1 2	15 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/history/thumbnail_database_unittest.cc	View	1 2	4 chunks	+5 lines, -18 lines	0 comments	Download
M	chrome/test/unit/unit_tests.scons	View	2	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/8191/diff/207/7 File chrome/browser/history/snippet_unittest.cc (right): http://codereview.chromium.org/8191/diff/207/7#newcode231 Line 231: const unsigned int expected_match_count; size_t?

12 years, 1 month ago (2008-11-06 18:06:55 UTC) #3

please use my chromium address

12 years, 1 month ago (2008-11-06 18:13:55 UTC) #4

On 2008/11/06 18:06:55, Mark Mentovai wrote:
> LGTM
> 
> http://codereview.chromium.org/8191/diff/207/7
> File chrome/browser/history/snippet_unittest.cc (right):
> 
> http://codereview.chromium.org/8191/diff/207/7#newcode231
> Line 231: const unsigned int expected_match_count;
> size_t?

Done. It probably doesn't require http://codereview.chromium.org/8618 because
only snippet_unittest is enabled, but a testbot run could be nice just to be
sure.

Expand Messages | Collapse Messages