Fix output not appearing in individual steps on android.

Fix output not appearing in individual steps on android.

Previously we were returning after writing out the chartjson data before getting a chance to print out the output from the previous step.

BUG=

Committed: https://crrev.com/9b9256d9b947be852f236490311801f6e8d0e5eb
Cr-Commit-Position: refs/heads/master@{#310317}

[shatch, 2014-12-22 20:50:07]

Patchset #1 (id:1) has been deleted

[shatch, 2014-12-22 21:07:47]

Patchset #1 (id:20001) has been deleted

[shatch, 2014-12-22 21:10:21]

[email protected] changed reviewers:
+ [email protected]

[jbudorick, 2015-01-04 20:11:36]

https://codereview.chromium.org/822813002/diff/40001/build/android/pylib/perf...
File build/android/pylib/perf/test_runner.py (right):

https://codereview.chromium.org/822813002/diff/40001/build/android/pylib/perf...
build/android/pylib/perf/test_runner.py:80: if not os.path.exists(file_name):
Should this cause a bot to go red?

https://codereview.chromium.org/822813002/diff/40001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/822813002/diff/40001/build/android/test_runne...
build/android/test_runner.py:771: perf_test_runner.OutputChartjson(
Do you want to run tests if test_runner.py perf is called with
--output-chartjson-data but not --print-step? Or do you just want to give
--print-step a chance to execute if --output-chartjson-data is specified? This
will currently do the former.

[shatch, 2015-01-05 15:06:32]

ptal

https://codereview.chromium.org/822813002/diff/40001/build/android/pylib/perf...
File build/android/pylib/perf/test_runner.py (right):

https://codereview.chromium.org/822813002/diff/40001/build/android/pylib/perf...
build/android/pylib/perf/test_runner.py:80: if not os.path.exists(file_name):
On 2015/01/04 20:11:35, jbudorick wrote:
> Should this cause a bot to go red?

If I merge this function and PrintTestOutput, the bot should go red if this
fails. Will put up a version that does that.

https://codereview.chromium.org/822813002/diff/40001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/822813002/diff/40001/build/android/test_runne...
build/android/test_runner.py:771: perf_test_runner.OutputChartjson(
On 2015/01/04 20:11:35, jbudorick wrote:
> Do you want to run tests if test_runner.py perf is called with
> --output-chartjson-data but not --print-step? Or do you just want to give
> --print-step a chance to execute if --output-chartjson-data is specified? This
> will currently do the former.

Intention is to output the chartjson data to a file in the same run that
print-step is called. Sounds like it might be better if I move the logic to
output the chartjson data into PrintTestOutput, CL looks a little cleaner this
way too.

[shatch, 2015-01-07 16:56:07]

On 2015/01/05 15:06:32, shatch wrote:
> ptal
> 
>
https://codereview.chromium.org/822813002/diff/40001/build/android/pylib/perf...
> File build/android/pylib/perf/test_runner.py (right):
> 
>
https://codereview.chromium.org/822813002/diff/40001/build/android/pylib/perf...
> build/android/pylib/perf/test_runner.py:80: if not os.path.exists(file_name):
> On 2015/01/04 20:11:35, jbudorick wrote:
> > Should this cause a bot to go red?
> 
> If I merge this function and PrintTestOutput, the bot should go red if this
> fails. Will put up a version that does that.
> 
>
https://codereview.chromium.org/822813002/diff/40001/build/android/test_runne...
> File build/android/test_runner.py (right):
> 
>
https://codereview.chromium.org/822813002/diff/40001/build/android/test_runne...
> build/android/test_runner.py:771: perf_test_runner.OutputChartjson(
> On 2015/01/04 20:11:35, jbudorick wrote:
> > Do you want to run tests if test_runner.py perf is called with
> > --output-chartjson-data but not --print-step? Or do you just want to give
> > --print-step a chance to execute if --output-chartjson-data is specified?
This
> > will currently do the former.
> 
> Intention is to output the chartjson data to a file in the same run that
> print-step is called. Sounds like it might be better if I move the logic to
> output the chartjson data into PrintTestOutput, CL looks a little cleaner this
> way too.

ping, look ok?

[jbudorick, 2015-01-07 16:59:49]

lgtm

[shatch, 2015-01-07 17:00:43]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-01-07 17:01:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/822813002/60001

[commit-bot: I haz the power, 2015-01-07 18:04:14]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-01-07 18:04:58]

Patchset 2 (id:??) landed as
https://crrev.com/9b9256d9b947be852f236490311801f6e8d0e5eb
Cr-Commit-Position: refs/heads/master@{#310317}