Issue 867033002: Replace the map in QuicAckNotifier with a counter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 867033002: Replace the map in QuicAckNotifier with a counter. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)

Modified:
5 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_AckNotifier_datastructures_84156430

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace the map in QuicAckNotifier with a counter. No functionality change. This reduces memory and CPU usage of the ack notifier. Merge internal change: 84345868 [email protected]

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -59 lines)			Patch
M	net/quic/quic_ack_notifier.h	View	1 chunk	+6 lines, -16 lines	0 comments	Download
M	net/quic/quic_ack_notifier.cc	View	3 chunks	+9 lines, -31 lines	0 comments	Download
M	net/quic/quic_ack_notifier_manager.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/quic_ack_notifier_manager.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/quic_ack_notifier_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages